YunoHost/yunohost
1
0
Fork 0
mirror of https://github.com/YunoHost/yunohost.git synced 2024-09-03 20:06:10 +02:00
Code Issues Projects Releases Packages Wiki Activity

apps: BACKUP_CORE_ONLY was not set for pre-upgrade safety backups, resulting in unecessarily large pre-upgrade backups

Browse source
This commit is contained in:
Alexandre Aubin 2023-08-22 15:37:47 +02:00
parent 576992899c
commit 07daa68770
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/app.py
View file

@ -707,9 +707,17 @@ def app_upgrade(
safety_backup_name = f"{app_instance_name}-pre-upgrade2" safety_backup_name = f"{app_instance_name}-pre-upgrade2"
other_safety_backup_name = f"{app_instance_name}-pre-upgrade1" other_safety_backup_name = f"{app_instance_name}-pre-upgrade1"
tweaked_backup_core_only = False
if "BACKUP_CORE_ONLY" not in os.environ:
tweaked_backup_core_only = True
os.environ["BACKUP_CORE_ONLY"] = "1"
try:
backup_create( backup_create(
name=safety_backup_name, apps=[app_instance_name], system=None name=safety_backup_name, apps=[app_instance_name], system=None
) )
finally:
if tweaked_backup_core_only:
del os.environ["BACKUP_CORE_ONLY"]
if safety_backup_name in backup_list()["archives"]: if safety_backup_name in backup_list()["archives"]:
# if the backup suceeded, delete old safety backup to save space # if the backup suceeded, delete old safety backup to save space