YunoHost/yunohost
1
0
Fork 0
mirror of https://github.com/YunoHost/yunohost.git synced 2024-09-03 20:06:10 +02:00
Code Issues Projects Releases Packages Wiki Activity

Apply suggestions from code review

Browse source 
Co-authored-by: Axolotle <nchesnais@mailoo.org>
This commit is contained in:
Alexandre Aubin 2022-02-09 20:08:39 +01:00
parent 40ad8ce25e
commit 0dc08c8f8c
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
share/config_domain.toml
View file

@ -71,6 +71,7 @@ i18n = "domain_config"
[cert.status.cert_validity] [cert.status.cert_validity]
type = "number" type = "number"
readonly = true readonly = true
visible = "false"
# Automatically filled by DomainConfigPanel # Automatically filled by DomainConfigPanel
[cert.cert] [cert.cert]
@ -89,6 +90,7 @@ i18n = "domain_config"
[cert.cert.acme_eligible_explain] [cert.cert.acme_eligible_explain]
type = "alert" type = "alert"
style = "warning"
visible = "acme_eligible == false" visible = "acme_eligible == false"
# FIXME: improve messaging ... # FIXME: improve messaging ...
ask = "Uhoh, domain isnt ready for ACME challenge according to the diagnosis" ask = "Uhoh, domain isnt ready for ACME challenge according to the diagnosis"

2
src/domain.py
View file

@ -544,7 +544,7 @@ def domain_action_run(
from yunohost.certificate import certificate_renew as action_func from yunohost.certificate import certificate_renew as action_func
args = dict(urllib.parse.parse_qsl(args or "", keep_blank_values=True)) args = dict(urllib.parse.parse_qsl(args or "", keep_blank_values=True))
no_checks = bool(args["cert_no_checks"]) no_checks = args["cert_no_checks"] in ("y", "yes", "on", "1")
action_func([domain], force=True, no_checks=no_checks) action_func([domain], force=True, no_checks=no_checks)