From 8adadf502b198caf6943b51433ab6d1799e0e0ca Mon Sep 17 00:00:00 2001 From: OniriCorpe Date: Thu, 2 Nov 2023 18:35:02 +0100 Subject: [PATCH 1/2] apply perms to the right file (I'm so tired lmao) --- helpers/logrotate | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helpers/logrotate b/helpers/logrotate index 076744efe..9587a68f9 100644 --- a/helpers/logrotate +++ b/helpers/logrotate @@ -99,7 +99,7 @@ $logfile { EOF mkdir --parents $(dirname "$logfile") # Create the log directory, if not exist cat ${app}-logrotate | $customtee /etc/logrotate.d/$app >/dev/null # Append this config to the existing config file, or replace the whole config file (depending on $customtee) - chmod 644 "$logfile" # Make sure permissions are correct (otherwise the config file could be ignored and the corresponding logs never rotated) + chmod 644 "/etc/logrotate.d/$app" # Make sure permissions are correct (otherwise the config file could be ignored and the corresponding logs never rotated) } # Remove the app's logrotate config. From 5c56cedc803b374dcd2787da52d639cd913125b8 Mon Sep 17 00:00:00 2001 From: OniriCorpe Date: Thu, 2 Nov 2023 18:38:07 +0100 Subject: [PATCH 2/2] fix indent --- helpers/logrotate | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/helpers/logrotate b/helpers/logrotate index 9587a68f9..de9f8d3c1 100644 --- a/helpers/logrotate +++ b/helpers/logrotate @@ -99,7 +99,7 @@ $logfile { EOF mkdir --parents $(dirname "$logfile") # Create the log directory, if not exist cat ${app}-logrotate | $customtee /etc/logrotate.d/$app >/dev/null # Append this config to the existing config file, or replace the whole config file (depending on $customtee) - chmod 644 "/etc/logrotate.d/$app" # Make sure permissions are correct (otherwise the config file could be ignored and the corresponding logs never rotated) + chmod 644 "/etc/logrotate.d/$app" # Make sure permissions are correct (otherwise the config file could be ignored and the corresponding logs never rotated) } # Remove the app's logrotate config.