From 31482e7d3129beebc4958829bbb2b478672b468b Mon Sep 17 00:00:00 2001 From: Laurent Peuch Date: Sun, 28 Apr 2019 03:50:49 +0200 Subject: [PATCH] [mod] use subprocess instead of os.system to ensure function has run correctly --- doc/generate_manpages.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/generate_manpages.py b/doc/generate_manpages.py index 85c6812cc..408ff883d 100644 --- a/doc/generate_manpages.py +++ b/doc/generate_manpages.py @@ -8,6 +8,7 @@ Pages are stored in OUTPUT_DIR import os import yaml +import subprocess THIS_SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__)) @@ -22,7 +23,7 @@ if not os.path.exists(OUTPUT_DIR): # man page of yunohost cmd = "sudo help2man \" yunohost \" -o " + OUTPUT_DIR + "yunohost" print(cmd) -os.system(cmd) +subprocess.check_call(cmd, shell=True) # man pages of "yunohost *" with open(ACTIONSMAP_FILE, 'r') as stream: @@ -41,4 +42,4 @@ with open(ACTIONSMAP_FILE, 'r') as stream: # print("yunohost", domain, action) cmd = "sudo help2man \" yunohost " + domain + " " + action + " --help \" -o " + OUTPUT_DIR + "yunohost_" + domain + "_" + action print(cmd) - os.system(cmd) + subprocess.check_call(cmd, shell=True)