From ee5a42eaed64957d8b1319dd4a821aa75793c1cd Mon Sep 17 00:00:00 2001
From: Maniack Crudelis <maniackcrudelis@users.noreply.github.com>
Date: Tue, 29 Nov 2016 14:00:15 +0100
Subject: [PATCH 1/3] Remove helper ynh_mkdir_tmp
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Le helper `ynh_mkdir_tmp` est inutile. Il existe la commande `mktemp -d` pour créer des dossiers temporaires.
---
 data/helpers.d/filesystem | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/data/helpers.d/filesystem b/data/helpers.d/filesystem
index 8a2bd9aff..41b570ad1 100644
--- a/data/helpers.d/filesystem
+++ b/data/helpers.d/filesystem
@@ -62,15 +62,3 @@ ynh_bind_or_cp() {
     echo "This helper is deprecated, you should use ynh_backup instead" >&2
     ynh_backup "$1" "$2" 1 "$NO_ROOT"
 }
-
-# Create a directory under /tmp
-#
-# usage: ynh_mkdir_tmp
-# | ret: the created directory path
-ynh_mkdir_tmp() {
-    TMPDIR="/tmp/$(ynh_string_random 6)"
-    while [ -d $TMPDIR ]; do
-        TMPDIR="/tmp/$(ynh_string_random 6)"
-    done
-    mkdir -p "$TMPDIR" && echo "$TMPDIR"
-}

From 261a304f37ea845481b1539e1383de56f4f75d7b Mon Sep 17 00:00:00 2001
From: Maniack Crudelis <maniackcrudelis@users.noreply.github.com>
Date: Tue, 29 Nov 2016 14:19:19 +0100
Subject: [PATCH 2/3] Update filesystem

---
 data/helpers.d/filesystem | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/data/helpers.d/filesystem b/data/helpers.d/filesystem
index 41b570ad1..d53a75a38 100644
--- a/data/helpers.d/filesystem
+++ b/data/helpers.d/filesystem
@@ -62,3 +62,13 @@ ynh_bind_or_cp() {
     echo "This helper is deprecated, you should use ynh_backup instead" >&2
     ynh_backup "$1" "$2" 1 "$NO_ROOT"
 }
+
+# Create a directory under /tmp
+#
+# Deprecated helper
+#
+# usage: ynh_mkdir_tmp
+# | ret: the created directory path
+ynh_mkdir_tmp() {
+    mktemp -d
+}

From 2bfbada570d9d194ddec39718474e780107d0fa9 Mon Sep 17 00:00:00 2001
From: opi <opi@zeropi.net>
Date: Tue, 29 Nov 2016 15:27:51 +0100
Subject: [PATCH 3/3] [enh] Add warning about deprecated ynh_mkdir_tmp helper

---
 data/helpers.d/filesystem | 1 +
 1 file changed, 1 insertion(+)

diff --git a/data/helpers.d/filesystem b/data/helpers.d/filesystem
index d53a75a38..3fc1b0eb8 100644
--- a/data/helpers.d/filesystem
+++ b/data/helpers.d/filesystem
@@ -70,5 +70,6 @@ ynh_bind_or_cp() {
 # usage: ynh_mkdir_tmp
 # | ret: the created directory path
 ynh_mkdir_tmp() {
+    echo "This helper is deprecated, you should use 'mktemp -d' instead." >&2
     mktemp -d
 }