From 356f2b9ec1362b33b03ca8254d9d25c2bfcc22f1 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Thu, 22 Aug 2019 12:42:25 +0200 Subject: [PATCH] Moar ideas --- data/hooks/diagnosis/00-basesystem.py | 2 ++ data/hooks/diagnosis/10-ip.py | 2 ++ data/hooks/diagnosis/12-dnsrecords.py | 2 ++ 3 files changed, 6 insertions(+) diff --git a/data/hooks/diagnosis/00-basesystem.py b/data/hooks/diagnosis/00-basesystem.py index 8fa90e65e..8bd522ee7 100644 --- a/data/hooks/diagnosis/00-basesystem.py +++ b/data/hooks/diagnosis/00-basesystem.py @@ -21,6 +21,8 @@ class BaseSystemDiagnoser(Diagnoser): status="INFO", summary=("diagnosis_basesystem_kernel", {"kernel_version": kernel_version})) + # FIXME / TODO : add virt/vm technology using systemd-detect-virt and/or machine arch + # Debian release debian_version = read_file("/etc/debian_version").strip() yield dict(meta={"test": "host"}, diff --git a/data/hooks/diagnosis/10-ip.py b/data/hooks/diagnosis/10-ip.py index 8c8dbe95b..e09dd343b 100644 --- a/data/hooks/diagnosis/10-ip.py +++ b/data/hooks/diagnosis/10-ip.py @@ -84,6 +84,8 @@ class IPDiagnoser(Diagnoser): summary=("diagnosis_ip_connected_ipv6", {}) if ipv6 else ("diagnosis_ip_no_ipv6", {})) + # TODO / FIXME : add some attempt to detect ISP (using whois ?) ? + def can_ping_outside(self, protocol=4): assert protocol in [4, 6], "Invalid protocol version, it should be either 4 or 6 and was '%s'" % repr(protocol) diff --git a/data/hooks/diagnosis/12-dnsrecords.py b/data/hooks/diagnosis/12-dnsrecords.py index 8c6565da9..e2f7bcc2d 100644 --- a/data/hooks/diagnosis/12-dnsrecords.py +++ b/data/hooks/diagnosis/12-dnsrecords.py @@ -33,6 +33,8 @@ class DNSRecordsDiagnoser(Diagnoser): # FIXME : somewhere, should implement a check for reverse DNS ... + # FIXME / TODO : somewhere, could also implement a check for domain expiring soon + def check_domain(self, domain, is_main_domain): expected_configuration = _build_dns_conf(domain)