From 45b36dae053b3f2e8670cc33a48482baaa1aa0d8 Mon Sep 17 00:00:00 2001
From: axolotle <nchesnais@mailoo.org>
Date: Sun, 26 Nov 2023 17:12:58 +0100
Subject: [PATCH] domain: reset portal_logo value even if file has already been
 removed

---
 src/domain.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/domain.py b/src/domain.py
index 8c4f71496..12c4d966c 100644
--- a/src/domain.py
+++ b/src/domain.py
@@ -781,11 +781,12 @@ class DomainConfigPanel(ConfigPanel):
                 if previous_settings.get("portal_logo"):
                     try:
                         os.remove(previous_settings["portal_logo"])
-                        portal_values["portal_logo"] = ''
-                    except:
+                    except FileNotFoundError:
                         logger.warning(
                             f"Coulnd't remove previous logo file, maybe the file was already deleted, path: {previous_settings['portal_logo']}"
                         )
+                    finally:
+                        portal_values["portal_logo"] = ""
 
                 if next_settings["portal_logo"]:
                     # Save the file content as `{mimetype}:{base64content}` in portal settings