From 47db3e798e43636e11db8118a74f92b304b06beb Mon Sep 17 00:00:00 2001
From: Alexandre Aubin <alex.aubin@mailoo.org>
Date: Thu, 16 Sep 2021 18:52:21 +0200
Subject: [PATCH] config helpers: Disable bash xtrace during
 ynh_read/write_var_from_file to avoid an horrendous amount of debug logs

---
 data/helpers.d/utils | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/data/helpers.d/utils b/data/helpers.d/utils
index ef019e894..1d9e6833c 100644
--- a/data/helpers.d/utils
+++ b/data/helpers.d/utils
@@ -519,6 +519,8 @@ ynh_read_var_in_file() {
 
     [[ -f $file ]] || ynh_die --message="File $file does not exists"
 
+    set +o xtrace # set +x
+
     # Get the line number after which we search for the variable
     local line_number=1
     if [[ -n "$after" ]];
@@ -526,6 +528,7 @@ ynh_read_var_in_file() {
         line_number=$(grep -n $after $file | cut -d: -f1)
         if [[ -z "$line_number" ]];
         then
+            set -o xtrace # set -x
             return 1
         fi
     fi
@@ -555,6 +558,7 @@ ynh_read_var_in_file() {
     # Extract the part after assignation sign
     local expression_with_comment="$(tail +$line_number ${file} | grep -i -o -P $var_part'\K.*$' || echo YNH_NULL | head -n1)"
     if [[ "$expression_with_comment" == "YNH_NULL" ]]; then
+        set -o xtrace # set -x
         echo YNH_NULL
         return 0
     fi
@@ -570,6 +574,7 @@ ynh_read_var_in_file() {
     else
         echo "$expression"
     fi
+    set -o xtrace # set -x
 }
 
 # Set a value into heterogeneous file (yaml, json, php, python...)
@@ -594,6 +599,8 @@ ynh_write_var_in_file() {
 
     [[ -f $file ]] || ynh_die --message="File $file does not exists"
 
+    set +o xtrace # set +x
+
     # Get the line number after which we search for the variable
     local line_number=1
     if [[ -n "$after" ]];
@@ -601,6 +608,7 @@ ynh_write_var_in_file() {
         line_number=$(grep -n $after $file | cut -d: -f1)
         if [[ -z "$line_number" ]];
         then
+            set -o xtrace # set -x
             return 1
         fi
     fi
@@ -631,6 +639,7 @@ ynh_write_var_in_file() {
     # Extract the part after assignation sign
     local expression_with_comment="$(tail +$line_number ${file} | grep -i -o -P $var_part'\K.*$' || echo YNH_NULL | head -n1)"
     if [[ "$expression_with_comment" == "YNH_NULL" ]]; then
+        set -o xtrace # set -x
         return 1
     fi
     
@@ -661,6 +670,7 @@ ynh_write_var_in_file() {
         fi
         sed -ri "${range}s$delimiter(^${var_part}).*\$$delimiter\1${value}${endline}${delimiter}i" ${file}
     fi
+    set -o xtrace # set -x
 }