From 4a8563ed9e86d4aaedc8b189373056b505a250b6 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Fri, 1 Mar 2019 01:43:16 +0100 Subject: [PATCH] Clarify the if case for 'get' --- data/helpers.d/setting | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/data/helpers.d/setting b/data/helpers.d/setting index 18a57780a..ccd2ac0a6 100644 --- a/data/helpers.d/setting +++ b/data/helpers.d/setting @@ -75,9 +75,11 @@ else: if action == "delete": if key in settings: del settings[key] - else: + elif action == "get": if key in ['redirected_urls', 'redirected_regex']: value = yaml.load(value) + else: + raise ValueError("action should either be get, set or delete") settings[key] = value with open(setting_file, "w") as f: yaml.safe_dump(settings, f, default_flow_style=False)