From 57665b6f11968dc60a65fa74a891004e135d3eb9 Mon Sep 17 00:00:00 2001 From: Laurent Peuch Date: Wed, 3 Jan 2018 19:23:47 +0100 Subject: [PATCH] [mod] uses builtin function to show traceback --- src/yunohost/dyndns.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/yunohost/dyndns.py b/src/yunohost/dyndns.py index d2137f91a..d65f5f7ed 100644 --- a/src/yunohost/dyndns.py +++ b/src/yunohost/dyndns.py @@ -302,14 +302,15 @@ def _migrate_from_md5_tsig_to_sha512_tsig(private_key_path, domain, dyn_host): if r.status_code != 201: try: error = json.loads(r.text)['error'] - except Exception as e: - import traceback - traceback.print_exc() - print e + show_traceback = 0 + except Exception: + # failed to decode json error = r.text + show_traceback = 1 logger.warning(m18n.n('migrate_tsig_failed', domain=domain, - error_code=str(r.status_code), error=error)) + error_code=str(r.status_code), error=error), + exc_info=show_traceback) os.system("mv /etc/yunohost/dyndns/*+165* /tmp") return public_key_path