From 68e97245175e846e7c737394f5d1577273d8b496 Mon Sep 17 00:00:00 2001 From: Laurent Peuch Date: Sun, 25 Aug 2019 16:40:41 +0200 Subject: [PATCH] [mod] remove catchall bad exception --- locales/en.json | 2 +- src/yunohost/dyndns.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/locales/en.json b/locales/en.json index b45739149..9cdb14483 100644 --- a/locales/en.json +++ b/locales/en.json @@ -185,7 +185,7 @@ "dyndns_could_not_check_provide": "Could not check if {provider:s} can provide {domain:s}.", "dyndns_could_not_check_available": "Could not check if {domain:s} is available on {provider:s}.", "dyndns_cron_installed": "The DynDNS cron job has been installed", - "dyndns_cron_remove_failed": "Unable to remove the DynDNS cron job", + "dyndns_cron_remove_failed": "Unable to remove the DynDNS cron job because: {error}", "dyndns_cron_removed": "The DynDNS cron job has been removed", "dyndns_ip_update_failed": "Unable to update IP address on DynDNS", "dyndns_ip_updated": "Your IP address has been updated on DynDNS", diff --git a/src/yunohost/dyndns.py b/src/yunohost/dyndns.py index 2dadcef52..c4558d79c 100644 --- a/src/yunohost/dyndns.py +++ b/src/yunohost/dyndns.py @@ -325,8 +325,8 @@ def dyndns_removecron(): """ try: os.remove("/etc/cron.d/yunohost-dyndns") - except: - raise YunohostError('dyndns_cron_remove_failed') + except Exception as e: + raise YunohostError('dyndns_cron_remove_failed', error=e) logger.success(m18n.n('dyndns_cron_removed'))