From 70a8225b1de0f9f36d0d8d727e4c218d7ecd30a5 Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Mon, 21 Nov 2022 18:53:09 +0100 Subject: [PATCH] diagnosis: make the dnsrecord diagnoser not complain about the damn 128 vs 0 stuff in CAA records --- src/diagnosers/12-dnsrecords.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/diagnosers/12-dnsrecords.py b/src/diagnosers/12-dnsrecords.py index ad09752b2..92d795ea9 100644 --- a/src/diagnosers/12-dnsrecords.py +++ b/src/diagnosers/12-dnsrecords.py @@ -223,6 +223,11 @@ class MyDiagnoser(Diagnoser): expected = r["value"].split()[-1] current = r["current"].split()[-1] return expected == current + elif r["type"] == "CAA": + # For CAA, check only the last item, ignore the 0 / 128 nightmare + expected = r["value"].split()[-1] + current = r["current"].split()[-1] + return expected == current else: return r["current"] == r["value"]