From 7674ba5cebf27dec8136f25ddcf4400b94ab9f18 Mon Sep 17 00:00:00 2001
From: "ljf (zamentur)" <zamentur@users.noreply.github.com>
Date: Wed, 22 May 2024 00:02:42 +0200
Subject: [PATCH] [fix] Forbidden keywords config panel

---
 src/utils/form.py | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/utils/form.py b/src/utils/form.py
index fb7956d50..21f4b2015 100644
--- a/src/utils/form.py
+++ b/src/utils/form.py
@@ -272,6 +272,14 @@ FORBIDDEN_READONLY_TYPES = {
     OptionType.user,
     OptionType.group,
 }
+
+# To simplify AppConfigPanel bash scripts, we've chosen to use question 
+# short_ids as global variables. The consequence is that there is a risk 
+# of collision with other variables, notably different global variables 
+# used to expose old values or the type of a question...
+# In addition to conflicts with bash variables, there is a direct
+# conflict with the TOML properties of sections, so the keywords `name`, 
+# `visible`, `services`, `optional` and `help` cannot be used either.
 FORBIDDEN_KEYWORDS = {
     "old",
     "app",
@@ -289,8 +297,11 @@ FORBIDDEN_KEYWORDS = {
     "changes_validated",
     "result",
     "max_progression",
-    "properties",
-    "defaults",
+    "name",
+    "visible",
+    "services",
+    "optional",
+    "help",
 }
 
 Context = dict[str, Any]