From 96e67ef1459ca4f8446206e68bb00ba0b2da543c Mon Sep 17 00:00:00 2001
From: Kay0u <pierre@kayou.io>
Date: Tue, 6 Jul 2021 12:14:46 +0200
Subject: [PATCH] monkey patch get_setting_description

---
 src/yunohost/settings.py            | 13 ++++++-------
 src/yunohost/tests/test_settings.py |  9 +++++++++
 2 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/src/yunohost/settings.py b/src/yunohost/settings.py
index 0466d8126..28f5bc687 100644
--- a/src/yunohost/settings.py
+++ b/src/yunohost/settings.py
@@ -265,19 +265,18 @@ def settings_reset_all():
     }
 
 
+def _get_setting_description(key):
+    return m18n.n("global_settings_setting_%s" % key.replace(".", "_"))
+
+
 def _get_settings():
-    def get_setting_description(key):
-        if key.startswith("example"):
-            # (This is for dummy stuff used during unit tests)
-            return "Dummy %s setting" % key.split(".")[-1]
-        return m18n.n("global_settings_setting_%s" % key.replace(".", "_"))
 
     settings = {}
 
     for key, value in DEFAULTS.copy().items():
         settings[key] = value
         settings[key]["value"] = value["default"]
-        settings[key]["description"] = get_setting_description(key)
+        settings[key]["description"] = _get_setting_description(key)
 
     if not os.path.exists(SETTINGS_PATH):
         return settings
@@ -306,7 +305,7 @@ def _get_settings():
             for key, value in local_settings.items():
                 if key in settings:
                     settings[key] = value
-                    settings[key]["description"] = get_setting_description(key)
+                    settings[key]["description"] = _get_setting_description(key)
                 else:
                     logger.warning(
                         m18n.n(
diff --git a/src/yunohost/tests/test_settings.py b/src/yunohost/tests/test_settings.py
index 47f8efdf4..1a9063e56 100644
--- a/src/yunohost/tests/test_settings.py
+++ b/src/yunohost/tests/test_settings.py
@@ -5,6 +5,8 @@ import pytest
 
 from yunohost.utils.error import YunohostError
 
+import yunohost.settings as settings
+
 from yunohost.settings import (
     settings_get,
     settings_list,
@@ -33,6 +35,13 @@ def teardown_function(function):
         os.remove(filename)
 
 
+def monkey_get_setting_description(key):
+    return "Dummy %s setting" % key.split(".")[-1]
+
+
+settings._get_setting_description = monkey_get_setting_description
+
+
 def test_settings_get_bool():
     assert settings_get("example.bool")