From 88b414c8f3e0d3192a057f18260b65b9e3b1b23e Mon Sep 17 00:00:00 2001
From: Alexandre Aubin <alex.aubin@mailoo.org>
Date: Thu, 25 Feb 2021 16:44:55 +0100
Subject: [PATCH] Don't redact empty string...

---
 src/yunohost/log.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/yunohost/log.py b/src/yunohost/log.py
index c51628c50..a5501557d 100644
--- a/src/yunohost/log.py
+++ b/src/yunohost/log.py
@@ -376,7 +376,11 @@ class RedactingFormatter(Formatter):
         msg = super(RedactingFormatter, self).format(record)
         self.identify_data_to_redact(msg)
         for data in self.data_to_redact:
-            msg = msg.replace(data, "**********")
+            # we check that data is not empty string,
+            # otherwise this may lead to super epic stuff
+            # (try to run "foo".replace("", "bar"))
+            if data:
+                msg = msg.replace(data, "**********")
         return msg
 
     def identify_data_to_redact(self, record):