This message about shell command return code is too technical and uninformative. Let's explain what happen, which is that some error occured inside the install script (and details are in the debug log).

This commit is contained in:
Alexandre Aubin 2019-09-26 16:33:15 +02:00
parent 47bdfd8654
commit 9331f44b34
2 changed files with 2 additions and 1 deletions

View file

@ -23,6 +23,7 @@
"app_incompatible": "The app {app} is incompatible with your YunoHost version",
"app_install_files_invalid": "These files cannot be installed",
"app_install_failed": "Could not install {app}",
"app_install_script_failed": "An error occured inside the app installation script.",
"app_location_already_used": "The app '{app}' is already installed in ({path})",
"app_make_default_location_already_used": "Can't make the app '{app}' the default on the domain, {domain} is already in use by the other app '{other_app}'",
"app_location_install_failed": "Cannot install the app there because it conflicts with the app '{other_app}' already installed in '{other_path}'",

View file

@ -917,7 +917,7 @@ def app_install(operation_logger, app, label=None, args=None, no_remove_on_failu
# "Common" app install failure : the script failed and returned exit code != 0
install_failed = (install_retcode != 0)
if install_failed:
error = m18n.n('unexpected_error', error='shell command return code: %s' % install_retcode)
error = m18n.n('app_install_script_failed')
logger.exception(error)
operation_logger.error(error)
# Script got manually interrupted ... N.B. : KeyboardInterrupt does not inherit from Exception