Fix permission_reset idempotency

src/yunohost/permission.py

@@ -217,6 +217,10 @@ def user_permission_reset(operation_logger, permission, sync_perm=True):
     if existing_permission is None:
         raise YunohostError('permission_not_found', permission=permission)
 
+    if existing_permission["allowed"] == ["all_users"]:
+        logger.warning("The permission was not updated all addition/removal requests already match the current state.")
+        return
+
     # Update permission with default (all_users)
 
     operation_logger.related_to.append(('app', permission.split(".")[0]))

src/yunohost/tests/test_permission.py

@@ -306,6 +306,17 @@ def test_permission_reset():
     assert res['blog.main']['allowed'] == ["all_users"]
     assert set(res['blog.main']['corresponding_users']) == set(["alice", "bob"])
 
+
+def test_permission_reset_idempotency():
+    # Reset permission
+    user_permission_reset("blog.main")
+    user_permission_reset("blog.main")
+
+    res = user_permission_list(full=True)['permissions']
+    assert res['blog.main']['allowed'] == ["all_users"]
+    assert set(res['blog.main']['corresponding_users']) == set(["alice", "bob"])
+
+
 #
 # Error on update function
 #