From abe421caa87a7d7f99565c51192805f17b1ca344 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josu=C3=A9=20Tille?= Date: Wed, 29 Apr 2020 13:42:14 +0200 Subject: [PATCH] Change default value for protected permission to 'false' --- data/helpers.d/setting | 2 +- src/yunohost/permission.py | 2 +- src/yunohost/tests/test_permission.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/data/helpers.d/setting b/data/helpers.d/setting index 5d2db657c..c3da11de3 100644 --- a/data/helpers.d/setting +++ b/data/helpers.d/setting @@ -193,7 +193,7 @@ ynh_webpath_register () { # | Default is false (for the permission different than 'main'). # | arg: -P, protected= - (optional) Define if this permission is protected. If it is protected the administrator # | won't be able to add or remove the visitors group of this permission. -# | By default it's 'true' (for the permission different than 'main'). +# | By default it's 'false' # # If provided, 'url' or 'additional_urls' is assumed to be relative to the app domain/path if they # start with '/'. For example: diff --git a/src/yunohost/permission.py b/src/yunohost/permission.py index 98a3ffd2b..610d18752 100644 --- a/src/yunohost/permission.py +++ b/src/yunohost/permission.py @@ -260,7 +260,7 @@ def user_permission_info(permission): def permission_create(operation_logger, permission, allowed=None, url=None, additional_urls=None, auth_header=True, label=None, show_tile=False, - protected=True, sync_perm=True): + protected=False, sync_perm=True): """ Create a new permission for a specific application diff --git a/src/yunohost/tests/test_permission.py b/src/yunohost/tests/test_permission.py index 659e28667..fc86c8dcc 100644 --- a/src/yunohost/tests/test_permission.py +++ b/src/yunohost/tests/test_permission.py @@ -352,7 +352,7 @@ def test_permission_create_extra(mocker): # all_users is only enabled by default on .main perms assert "all_users" not in res['site.test']['allowed'] assert res['site.test']['corresponding_users'] == [] - assert res['site.test']['protected'] == True + assert res['site.test']['protected'] == False def test_permission_create_with_specific_user():