From b2a26a64a74d2f7289d857b7bb780ac2f91741ce Mon Sep 17 00:00:00 2001
From: Alexandre Aubin <alex.aubin@mailoo.org>
Date: Sun, 15 Sep 2019 18:33:31 +0200
Subject: [PATCH] Naively migrate legacy and classical unprotected_uris = /
 that sets the app as public

---
 src/yunohost/app.py                                       | 8 +++++++-
 .../data_migrations/0011_setup_group_permission.py        | 6 ++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/yunohost/app.py b/src/yunohost/app.py
index 8b0c99d46..537616e68 100644
--- a/src/yunohost/app.py
+++ b/src/yunohost/app.py
@@ -733,7 +733,7 @@ def app_install(operation_logger, app, label=None, args=None, no_remove_on_failu
 
     from yunohost.hook import hook_add, hook_remove, hook_exec, hook_callback
     from yunohost.log import OperationLogger
-    from yunohost.permission import user_permission_list, permission_create, permission_urls, permission_delete, permission_sync_to_user
+    from yunohost.permission import user_permission_list, permission_create, permission_urls, permission_delete, permission_sync_to_user, user_permission_update
 
     # Fetch or extract sources
     if not os.path.exists(INSTALL_TMP):
@@ -952,7 +952,13 @@ def app_install(operation_logger, app, label=None, args=None, no_remove_on_failu
     domain = app_settings.get('domain', None)
     path = app_settings.get('path', None)
     if domain and path:
+        # FIXME : might want to move this to before running the install script because some app need to run install script during initialization etc (idk) ?
         permission_urls(app_instance_name+".main", add=[domain+path], sync_perm=False)
+
+    # Migrate classic public app still using the legacy unprotected_uris
+    if app_settings.get("unprotected_uris", None) == "/":
+        user_permission_update(app_instance_name+".main", remove="all_users", add="visitors", sync_perm=False)
+
     permission_sync_to_user()
 
     logger.success(m18n.n('installation_complete'))
diff --git a/src/yunohost/data_migrations/0011_setup_group_permission.py b/src/yunohost/data_migrations/0011_setup_group_permission.py
index b3e11cb14..c79d80e0c 100644
--- a/src/yunohost/data_migrations/0011_setup_group_permission.py
+++ b/src/yunohost/data_migrations/0011_setup_group_permission.py
@@ -113,6 +113,12 @@ class MyMigration(Migration):
                 user_permission_update(app+".main", remove="all_users", add=allowed_group, sync_perm=False)
             app_setting(app, 'allowed_users', delete=True)
 
+            # Migrate classic public app still using the legacy unprotected_uris
+            if app_setting(app, "unprotected_uris") == "/":
+                user_permission_update(app+".main", remove="all_users", add="visitors", sync_perm=False)
+
+            permission_sync_to_user()
+
     def run(self):
 
         # FIXME : what do we really want to do here ...