YunoHost/yunohost
1
0
Fork 0
mirror of https://github.com/YunoHost/yunohost.git synced 2024-09-03 20:06:10 +02:00
Code Issues Projects Releases Packages Wiki Activity

Custom service description: let's be a bit smarter and use the one from the systemd service if it exists

Browse source
This commit is contained in:
Alexandre Aubin 2019-12-01 18:41:47 +01:00
parent fea733ce31
commit c97a839630
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/yunohost/service.py
View file

@ -79,7 +79,16 @@ def service_add(name, description=None, log=None, log_type="file", test_status=N
if description: if description:
services[name]['description'] = description services[name]['description'] = description
else: else:
logger.warning("/!\\ Packager ! You added a custom service without specifying a description. Please add --description to explain what the service does in a similar fashion to existing services.") # Try to get the description from systemd service
out = subprocess.check_output("systemctl show %s | grep '^Description='" % name, shell=True)
out = out.replace("Description=", "")
# If the service does not yet exists or if the description is empty,
# systemd will anyway return foo.service as default value, so we wanna
# make sure there's actually something here.
if out == name + ".service":
logger.warning("/!\\ Packager ! You added a custom service without specifying a description. Please add a proper Description in the systemd configuration, or use --description to explain what the service does in a similar fashion to existing services.")
else:
services[name]['description'] = out
if need_lock: if need_lock:
services[name]['need_lock'] = True services[name]['need_lock'] = True