From cbc1c82df7fbe221fa3262c9f6aa50893662b657 Mon Sep 17 00:00:00 2001
From: Kay0u <pierre.moltess@gmail.com>
Date: Sun, 10 Nov 2019 22:08:33 +0900
Subject: [PATCH] Fix parameters

---
 data/helpers.d/setting | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/data/helpers.d/setting b/data/helpers.d/setting
index bf4e804ec..adc318bef 100644
--- a/data/helpers.d/setting
+++ b/data/helpers.d/setting
@@ -271,20 +271,18 @@ ynh_permission_create() {
         url="None"
     fi
 
-    if [[ -n ${allowed:-} ]]; then
-        allowed=",allowed=['${allowed//';'/"','"}']"
-    fi
-
     # Check if permission already exists
     if ynh_permission_exists --permission $permission; then
         # If permission exits, update it
-        local add
-        if [[ -n ${add:-} ]]; then
-            add="--add ${allowed//';'/" "}"
+        if [[ -n ${allowed:-} ]]; then
+            allowed="--add ${allowed//';'/" "}"
         fi
-        ynh_exec_warn_less ynh_permission_update --permission $permission ${add:-}
+        ynh_exec_warn_less ynh_permission_update --permission $permission ${allowed:-}
     else
         # If not, create it
+        if [[ -n ${allowed:-} ]]; then
+            allowed=",allowed=['${allowed//';'/"','"}']"
+        fi
         yunohost tools shell -c "from yunohost.permission import permission_create; permission_create('$app.$permission', url=$url ${allowed:-} , sync_perm=False)"
     fi
 }