From d376677db6314c5aec623420dc25e3173ce3b3fc Mon Sep 17 00:00:00 2001 From: Alexandre Aubin Date: Tue, 30 Jul 2024 15:50:45 +0200 Subject: [PATCH] diagnosis: be more robust when diagnosis DMARC records not containing '=' --- src/diagnosers/12-dnsrecords.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/diagnosers/12-dnsrecords.py b/src/diagnosers/12-dnsrecords.py index 041030553..d63e54c9c 100644 --- a/src/diagnosers/12-dnsrecords.py +++ b/src/diagnosers/12-dnsrecords.py @@ -217,7 +217,9 @@ class MyDiagnoser(Diagnoser): } if "v=DMARC1" in r["value"]: for param in current: - key, value = param.split("=") + if "=" not in param: + return False + key, value = param.split("=", 1) if key == "p": return value in ["none", "quarantine", "reject"] return expected == current