From db93b82b23d0470a8dcde3393e67002e2d975fd8 Mon Sep 17 00:00:00 2001
From: Alexandre Aubin <alex.aubin@mailoo.org>
Date: Mon, 8 Mar 2021 18:41:54 +0100
Subject: [PATCH] ynh_setup_source: add a check that we could actually parse
 SOURCE_URL

---
 data/helpers.d/utils | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/data/helpers.d/utils b/data/helpers.d/utils
index 487ec41db..8246b9986 100644
--- a/data/helpers.d/utils
+++ b/data/helpers.d/utils
@@ -135,12 +135,15 @@ ynh_setup_source () {
     if [ "$src_filename" = "" ]; then
         src_filename="${source_id}.${src_format}"
     fi
-    local local_src="/opt/yunohost-apps-src/${YNH_APP_ID}/${src_filename}"
 
+    # (Unused?) mecanism where one can have the file in a special local cache to not have to download it...
+    local local_src="/opt/yunohost-apps-src/${YNH_APP_ID}/${src_filename}"
     if test -e "$local_src"
-    then    # Use the local source file if it is present
+    then
         cp $local_src $src_filename
-    else    # If not, download the source
+    else
+        [ -n "$src_url" ] || ynh_die "Couldn't parse SOURCE_URL from $src_file_path ?"
+
         # NB. we have to declare the var as local first,
         # otherwise 'local foo=$(false) || echo 'pwet'" does'nt work
         # because local always return 0 ...