From e00d60b0492ddea17e3be384ee30b3dcc96627f5 Mon Sep 17 00:00:00 2001 From: Tagada <36127788+Tagadda@users.noreply.github.com> Date: Sat, 21 Jan 2023 13:40:04 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Alexandre Aubin --- src/diagnosers/14-ports.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/diagnosers/14-ports.py b/src/diagnosers/14-ports.py index 0cd54efba..57fb7cd98 100644 --- a/src/diagnosers/14-ports.py +++ b/src/diagnosers/14-ports.py @@ -121,7 +121,7 @@ class MyDiagnoser(Diagnoser): for record in dnsrecords.get("items", []) ) - if failed == 4 and settings_get("misc.network.dns_exposure") != "ipv6" or ipv6_is_important(): + if (failed == 4 and settings_get("misc.network.dns_exposure") in ["both", "ipv4"]) or (failed == 6 and ipv6_is_important()): yield dict( meta={"port": port}, data={