From e07e1a95f4e223808d15fed8098d67f27de01653 Mon Sep 17 00:00:00 2001
From: Alexandre Aubin <alex.aubin@mailoo.org>
Date: Tue, 16 Jun 2020 21:31:24 +0200
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Kayou <pierre@kayou.io>
---
 data/helpers.d/apt | 4 ++--
 data/helpers.d/php | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/data/helpers.d/apt b/data/helpers.d/apt
index f662c58e4..8b284d4fc 100644
--- a/data/helpers.d/apt
+++ b/data/helpers.d/apt
@@ -329,7 +329,7 @@ EOF
         update-alternatives --set php /usr/bin/php$YNH_DEFAULT_PHP_VERSION
 
         # Store phpversion into the config of this app
-        ynh_app_setting_set $app phpversion $specific_php_version
+        ynh_app_setting_set --app=$app --key=phpversion --value=$specific_php_version
 
         # Integrate new php-fpm service in yunohost
         yunohost service add php${specific_php_version}-fpm --log "/var/log/php${phpversion}-fpm.log"
@@ -435,7 +435,7 @@ ynh_install_extra_app_dependencies () {
     ynh_install_extra_repo --repo="$repo" $key --priority=995 --name=$name
 
     # Install requested dependencies from this extra repository.
-    ynh_install_app_dependencies --package="$package"
+    ynh_install_app_dependencies "$package"
 
     # Remove this extra repository after packages are installed
     ynh_remove_extra_repo --name=$app
diff --git a/data/helpers.d/php b/data/helpers.d/php
index 2191b0d22..d383c1e4f 100644
--- a/data/helpers.d/php
+++ b/data/helpers.d/php
@@ -336,7 +336,7 @@ ynh_install_php () {
     fi
 
     ynh_install_app_dependencies "$package"
-    ynh_app_setting_set $app phpversion $phpversion
+    ynh_app_setting_set --app=$app --key=phpversion --value=$specific_php_version
 }
 
 # Remove the specific version of PHP used by the app.