Merge pull request #766 from YunoHost/avoid_silent_exception

[mod] remove silent exception in toos_update
This commit is contained in:
Alexandre Aubin 2019-08-04 17:58:56 +02:00 committed by GitHub
commit e2899c8158
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions

View file

@ -539,6 +539,7 @@
"system_upgraded": "The system has been upgraded", "system_upgraded": "The system has been upgraded",
"system_username_exists": "Username already exists in the system users", "system_username_exists": "Username already exists in the system users",
"this_action_broke_dpkg": "This action broke dpkg/apt (the system package managers)... You can try to solve this issue by connecting through SSH and running `sudo dpkg --configure -a`.", "this_action_broke_dpkg": "This action broke dpkg/apt (the system package managers)... You can try to solve this issue by connecting through SSH and running `sudo dpkg --configure -a`.",
"tools_update_failed_to_app_fetchlist": "Failed to update YunoHost's applists because: {error}",
"tools_upgrade_at_least_one": "Please specify --apps OR --system", "tools_upgrade_at_least_one": "Please specify --apps OR --system",
"tools_upgrade_cant_both": "Cannot upgrade both system and apps at the same time", "tools_upgrade_cant_both": "Cannot upgrade both system and apps at the same time",
"tools_upgrade_cant_hold_critical_packages": "Unable to hold critical packages ...", "tools_upgrade_cant_hold_critical_packages": "Unable to hold critical packages ...",

View file

@ -520,9 +520,8 @@ def tools_update(apps=False, system=False):
logger.info(m18n.n('updating_app_lists')) logger.info(m18n.n('updating_app_lists'))
try: try:
app_fetchlist() app_fetchlist()
except YunohostError: except YunohostError as e:
# FIXME : silent exception !? logger.error(m18n.n('tools_update_failed_to_app_fetchlist'), error=e)
pass
upgradable_apps = list(_list_upgradable_apps()) upgradable_apps = list(_list_upgradable_apps())