From e2def749970481144b6a2e52f11c4f8df2e39998 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josu=C3=A9=20Tille?= Date: Mon, 30 Dec 2019 13:28:56 +0100 Subject: [PATCH] Improve check before permission update --- src/yunohost/permission.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/yunohost/permission.py b/src/yunohost/permission.py index 8275a96a0..4e7bd8a5b 100644 --- a/src/yunohost/permission.py +++ b/src/yunohost/permission.py @@ -166,7 +166,8 @@ def user_permission_update(operation_logger, permission, add=None, remove=None, raise YunohostError('permission_cannot_remove_all_users_while_visitors_allowed') # Don't update LDAP if we update exactly the same values - if set(new_allowed_groups) == set(current_allowed_groups) and protected is None: + if set(new_allowed_groups) == set(current_allowed_groups) and \ + (protected is None or protected == existing_permission["protected"]): logger.warning(m18n.n("permission_already_up_to_date")) return existing_permission