From e8bf6eec80d15999ef4f3f1374b973e3785b1295 Mon Sep 17 00:00:00 2001
From: Kay0u <pierre.moltess@gmail.com>
Date: Mon, 11 Nov 2019 09:56:09 +0900
Subject: [PATCH] fail if permission already exists

---
 data/helpers.d/setting | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/data/helpers.d/setting b/data/helpers.d/setting
index adc318bef..8046dfab4 100644
--- a/data/helpers.d/setting
+++ b/data/helpers.d/setting
@@ -271,20 +271,11 @@ ynh_permission_create() {
         url="None"
     fi
 
-    # Check if permission already exists
-    if ynh_permission_exists --permission $permission; then
-        # If permission exits, update it
-        if [[ -n ${allowed:-} ]]; then
-            allowed="--add ${allowed//';'/" "}"
-        fi
-        ynh_exec_warn_less ynh_permission_update --permission $permission ${allowed:-}
-    else
-        # If not, create it
-        if [[ -n ${allowed:-} ]]; then
-            allowed=",allowed=['${allowed//';'/"','"}']"
-        fi
-        yunohost tools shell -c "from yunohost.permission import permission_create; permission_create('$app.$permission', url=$url ${allowed:-} , sync_perm=False)"
+    if [[ -n ${allowed:-} ]]; then
+        allowed=",allowed=['${allowed//';'/"','"}']"
     fi
+    
+    yunohost tools shell -c "from yunohost.permission import permission_create; permission_create('$app.$permission', url=$url ${allowed:-} , sync_perm=False)"
 }
 
 # Remove a permission for the app (note that when the app is removed all permission is automatically removed)