From e9802ce2dca0f91a175f121ebc31ff6f9a99c1f4 Mon Sep 17 00:00:00 2001
From: axolotle <nchesnais@mailoo.org>
Date: Wed, 27 Sep 2023 19:31:50 +0200
Subject: [PATCH] domain dyndns: do not save recovery password

---
 src/domain.py | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/src/domain.py b/src/domain.py
index b68c7dffc..154da54dc 100644
--- a/src/domain.py
+++ b/src/domain.py
@@ -317,11 +317,6 @@ def domain_add(
             pass
         raise e
 
-    if dyndns and dyndns_recovery_password:
-        domain_config_set(
-            domain, "dns.registrar.recovery_password", dyndns_recovery_password
-        )
-
     hook_callback("post_domain_add", args=[domain])
 
     logger.success(m18n.n("domain_created"))
@@ -710,13 +705,14 @@ class DomainConfigPanel(ConfigPanel):
                     other_app=app_map(raw=True)[self.entity]["/"]["id"],
                 )
         if (
-            "recovery_password" in self.future_values
-            and self.future_values["recovery_password"]
-            != self.values["recovery_password"]
+            "recovery_password" in self.new_values
+            and self.new_values["recovery_password"]
         ):
             domain_dyndns_set_recovery_password(
-                self.entity, self.future_values["recovery_password"]
+                self.entity, self.new_values["recovery_password"]
             )
+        # Do not save password in yaml settings
+        del self.new_values["recovery_password"]
 
         super()._apply()