From 6e427374ec614db7f0ae946af87da30c0f57e534 Mon Sep 17 00:00:00 2001
From: Kay0u <pierre.moltess@gmail.com>
Date: Thu, 16 Jan 2020 00:34:11 +0700
Subject: [PATCH 1/2] fix legacy permission management

---
 data/helpers.d/setting | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/data/helpers.d/setting b/data/helpers.d/setting
index c862d4ef6..b07b552af 100644
--- a/data/helpers.d/setting
+++ b/data/helpers.d/setting
@@ -187,9 +187,15 @@ EOF
 
     # Fucking legacy permission management.
     # We need this because app temporarily set the app as unprotected to configure it with curl...
-    if [[ "$3" =~ ^(unprotected|skipped)_ ]] && [[ "${4:-}" == "/" ]]
+    if [[ "$3" =~ ^(unprotected|skipped)_ ]]
     then
-        ynh_permission_update --permission "main" --add "visitors"
+        if [[ "$1" == "set" ]] && [[ "${4:-}" == "/" ]]
+        then
+            ynh_permission_update --permission "main" --add "visitors"
+        elif [[ "$1" == "delete" ]]
+        then
+            ynh_permission_update --permission "main" --remove "visitors"
+        fi
     fi
 }
 

From 026c666d7e2e8a826e0e7c986ec51977c685950c Mon Sep 17 00:00:00 2001
From: Kay0u <pierre.moltess@gmail.com>
Date: Wed, 29 Jan 2020 14:24:59 +0700
Subject: [PATCH 2/2] remove visitors only for if current value is /

---
 data/helpers.d/setting | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/data/helpers.d/setting b/data/helpers.d/setting
index b07b552af..384fdc399 100644
--- a/data/helpers.d/setting
+++ b/data/helpers.d/setting
@@ -158,6 +158,11 @@ ynh_add_protected_uris() {
 #
 ynh_app_setting()
 {
+    if [[ "$1" == "delete" ]] && [[ "$3" =~ ^(unprotected|skipped)_ ]] 
+    then
+        current_value=$(ynh_app_setting_get --app=$app --key=$3)
+    fi
+
     ACTION="$1" APP="$2" KEY="$3" VALUE="${4:-}" python2.7 - <<EOF
 import os, yaml, sys
 app, action = os.environ['APP'], os.environ['ACTION'].lower()
@@ -192,7 +197,7 @@ EOF
         if [[ "$1" == "set" ]] && [[ "${4:-}" == "/" ]]
         then
             ynh_permission_update --permission "main" --add "visitors"
-        elif [[ "$1" == "delete" ]]
+        elif [[ "$1" == "delete" ]] && [[ "${current_value:-}" == "/" ]]
         then
             ynh_permission_update --permission "main" --remove "visitors"
         fi