user_permission_list: use the new apps arg when we can

This commit is contained in:
Kay0u 2021-04-13 13:22:07 +02:00
parent bd72a59e1f
commit f6687e69f8
No known key found for this signature in database
GPG key ID: AAFEEB16CFA2AE2D
2 changed files with 7 additions and 10 deletions

View file

@ -324,9 +324,9 @@ def app_map(app=None, raw=False, user=None):
app,
]
else:
apps = os.listdir(APPS_SETTING_PATH)
apps = _installed_apps()
permissions = user_permission_list(full=True, absolute_urls=True)["permissions"]
permissions = user_permission_list(full=True, absolute_urls=True, apps=apps)["permissions"]
for app_id in apps:
app_settings = _get_app_settings(app_id)
if not app_settings:
@ -1096,8 +1096,7 @@ def app_install(
)
# Remove all permission in LDAP
for permission_name in user_permission_list()["permissions"].keys():
if permission_name.startswith(app_instance_name + "."):
for permission_name in user_permission_list(apps=[app_instance_name])["permissions"].keys():
permission_delete(permission_name, force=True, sync_perm=False)
if remove_retcode != 0:

View file

@ -726,11 +726,10 @@ class BackupManager:
# backup permissions
logger.debug(m18n.n("backup_permission", app=app))
permissions = user_permission_list(full=True)["permissions"]
permissions = user_permission_list(full=True, apps=[app])["permissions"]
this_app_permissions = {
name: infos
for name, infos in permissions.items()
if name.startswith(app + ".")
}
write_to_yaml("%s/permissions.yml" % settings_dir, this_app_permissions)
@ -1547,8 +1546,7 @@ class RestoreManager:
shutil.rmtree(app_settings_new_path, ignore_errors=True)
# Remove all permission in LDAP for this app
for permission_name in user_permission_list()["permissions"].keys():
if permission_name.startswith(app_instance_name + "."):
for permission_name in user_permission_list(apps=[app_instance_name])["permissions"].keys():
permission_delete(permission_name, force=True)
# TODO Cleaning app hooks