Commit graph

1545 commits

Author SHA1 Message Date
Alexandre Aubin
9294664d6c Fix permission backward compatibility for the case where an app needs to make the app temporarily public during install script... 2019-10-26 17:46:51 +02:00
Alexandre Aubin
17ce7bd95c Rework depreciation warning about legacy permission stuff 2019-10-26 17:46:51 +02:00
Alexandre Aubin
bd02678275 Refuse to add visitors to mail / xmpp / ... permission as it doesnt make sense 2019-10-24 17:47:43 +02:00
Alexandre Aubin
9beeb16077 Don't sync permission right away when deleting them, otherwise we get annoying warning because app_map thinks the app is still installed and expected a main permission 2019-10-20 04:17:25 +02:00
Alexandre Aubin
e005d94f82 Messed up the message UX with a previous PR (did not have the message explaining how to debug at the very end) 2019-10-20 04:17:25 +02:00
Alexandre Aubin
9362261d34 Ugh some apps uses skipped_uris sometimes instead of unprotected_uris... 2019-10-19 18:05:32 +02:00
Alexandre Aubin
7c99aff94e Forgot the i18n 2019-10-19 18:04:55 +02:00
Alexandre Aubin
b8ce8e9392 Try to make those debug messages sound less like an error 2019-10-19 05:34:42 +02:00
Alexandre Aubin
d9990cd818
Smarter regex to avoid redacting all --key=stuff when using setting helpers for example 2019-10-16 18:59:23 +02:00
Alexandre Aubin
a0fd531ef9
Merge branch 'stretch-unstable' into more-accurate-tests 2019-10-15 23:27:45 +02:00
Alexandre Aubin
cd89f119ff
Merge branch 'stretch-unstable' into permission-visitors 2019-10-15 23:23:56 +02:00
Alexandre Aubin
4def4dfa6a
[yolofix] Should have a list of string to be able to join() later 2019-10-15 14:54:52 +02:00
Alexandre Aubin
6dc720f3cf [yolo] Use read_json / write_to_json helpers to read/write ssowat conf.json.persistent 2019-10-15 02:36:12 +02:00
Alexandre Aubin
7d0119ade4 Fix backup info.json format... 2019-10-15 01:06:04 +02:00
Alexandre Aubin
61931f2c4b We don't want this to call .error() for legit logs already completed 2019-10-14 20:28:16 +02:00
Alexandre Aubin
08d9717236 Improve test accuracy for apps 2019-10-14 20:26:59 +02:00
Alexandre Aubin
3bc65ddc34 Merge branch 'stretch-unstable' into more-accurate-tests 2019-10-14 19:09:48 +02:00
Alexandre Aubin
1f2da5c26b
Merge branch 'stretch-unstable' into better-handling-of-app-install-and-remove-failures 2019-10-14 19:08:15 +02:00
Alexandre Aubin
c7ff6cb682
Merge branch 'permission-visitors' into more-accurate-tests 2019-10-13 22:03:55 +02:00
Alexandre Aubin
eb85744a1d Merge branch 'stretch-unstable' into permission-visitors 2019-10-10 00:13:12 +02:00
Alexandre Aubin
5882bf89db Merge branch 'stretch-testing' into stretch-unstable 2019-10-10 00:10:11 +02:00
Alexandre Aubin
2623d38567 Annnnnd Alex was drunk and released an epic stupid bug in stable 2019-10-10 00:06:36 +02:00
Alexandre Aubin
e48036a082 Fix test about private app installs 2019-10-10 00:05:20 +02:00
Alexandre Aubin
e4163136bb Don't attempt to delete the 'visitors' group during user/group tests 2019-10-09 23:40:50 +02:00
Alexandre Aubin
4bdcfb4373 Implement / fix i18n strings 2019-10-09 23:16:09 +02:00
Alexandre Aubin
e7d1cc5f94 Allow to specify right away what groups to allow for a permission when creating it 2019-10-09 23:02:57 +02:00
Alexandre Aubin
c315df9269 Wokay, getting tired of breaking the entire permission/group ecosystem because of bugs when developing. 2019-10-09 23:02:57 +02:00
Alexandre Aubin
2617fd2487 Fix issues related to regerating ssowat conf while hacking permissions... 2019-10-09 23:02:57 +02:00
Alexandre Aubin
88794805eb We probably don't need to have multiple urls per permissions ... 2019-10-09 23:02:37 +02:00
Alexandre Aubin
9cecd71437 Fix permission_reset idempotency 2019-10-09 19:39:37 +02:00
Alexandre Aubin
96bc95656c Allow the migration to proceed if slapd config was manually modified, warn the user about where the conf will be backuped 2019-10-09 19:22:31 +02:00
Alexandre Aubin
795cae1a4b
Merge branch 'stretch-unstable' into permission-visitors 2019-10-09 18:57:23 +02:00
Alexandre Aubin
df49af0ad0 Redundant operation considering we're deleting all groups right after 2019-10-09 18:55:11 +02:00
Alexandre Aubin
4a14cbd6e0 Fix / implement remaining test 2019-10-09 18:42:43 +02:00
Alexandre Aubin
7ecefaf8dc Fixes following tests 2019-10-08 18:42:03 +02:00
Alexandre Aubin
5623689a27 Detect and warn early about unavailable full domain requirement... 2019-10-08 18:38:45 +02:00
Alexandre Aubin
ea1fd71def
Merge pull request #798 from YunoHost/detect-and-warn-early-about-unavailable-full-domain
[fix] Detect and warn early about unavailable full domains...
2019-10-08 18:35:31 +02:00
Alexandre Aubin
c70418c4b2 Fixes following tests 2019-10-08 18:21:04 +02:00
Alexandre Aubin
342fe2d4be Add unit test for full-domain apps 2019-10-08 18:19:50 +02:00
Alexandre Aubin
2642b64af5 Detect and warn early about unavailable full domain requirement... 2019-10-08 16:11:52 +02:00
Luke Murphy
a1822e2f42
Use str instead of strerror (not present)
See https://forum.yunohost.org/t/cant-create-a-user-after-post-intsallation/9190.
2019-10-06 11:25:01 +02:00
Alexandre Aubin
d063348d9b
Merge pull request #795 from YunoHost/improve-permission-interface
Polish group/permissions interface + simplify code
2019-10-04 20:02:35 +02:00
Alexandre Aubin
692ba7c5cd
Merge pull request #814 from YunoHost/spookier-warnings-for-app-install
Spookier warnings for dangerous app install
2019-10-04 19:42:23 +02:00
Alexandre Aubin
d159f7ff07
Misc typo / wording / readability
Co-Authored-By: decentral1se <lukewm@riseup.net>
2019-09-28 16:11:44 +02:00
Alexandre Aubin
6aebec4a34 Residual .migrate() -> .run() 2019-09-27 20:37:13 +02:00
Alexandre Aubin
babaf541b6 Decent quality is now at least level 5 2019-09-27 17:42:56 +02:00
Alexandre Aubin
a2ecbb9d8b Make the warning spooky for notworking and thirdparty apps ... 2019-09-27 17:41:09 +02:00
Alexandre Aubin
c0e3d600b2 If we got fed an app url, extract the name of the app to test if we do know it 2019-09-27 17:17:03 +02:00
Alexandre Aubin
ccc49a2b28 Simplify that indentation madness 2019-09-26 16:34:14 +02:00
Alexandre Aubin
9331f44b34 This message about shell command return code is too technical and uninformative. Let's explain what happen, which is that some error occured inside the install script (and details are in the debug log). 2019-09-26 16:33:15 +02:00