From 102dec555fa296d626641b6698b9d7a74b00e4a8 Mon Sep 17 00:00:00 2001 From: Laurent Peuch Date: Mon, 1 Apr 2019 18:13:33 +0200 Subject: [PATCH] [mod] actually websocket has a real method for that, maybe that will prevent leaks? --- run.py | 32 ++++---------------------------- 1 file changed, 4 insertions(+), 28 deletions(-) diff --git a/run.py b/run.py index 5a8b29d..c7ca560 100644 --- a/run.py +++ b/run.py @@ -515,13 +515,7 @@ async def ws_index(request, websocket): map(model_to_dict, latest_done_jobs)), })) - while True: - # ping periodically to remove dead connections - try: - await websocket.send("ping") - except ConnectionClosed: - return - await asyncio.sleep(60) + await websocket.wait_closed() @app.websocket('/job--ws') @@ -540,13 +534,7 @@ async def ws_job(request, websocket, job_id): "data": model_to_dict(job), })) - while True: - # ping periodically to remove dead connections - try: - await websocket.send("ping") - except ConnectionClosed: - return - await asyncio.sleep(60) + await websocket.wait_closed() @app.websocket('/apps-ws') @@ -642,13 +630,7 @@ async def ws_apps(request, websocket): "data": repos, })) - while True: - # ping periodically to remove dead connections - try: - await websocket.send("ping") - except ConnectionClosed: - return - await asyncio.sleep(60) + await websocket.wait_closed() @app.websocket('/app--ws') @@ -665,13 +647,7 @@ async def ws_app(request, websocket, app_name): app.url).order_by(-Job.id), })) - while True: - # ping periodically to remove dead connections - try: - await websocket.send("ping") - except ConnectionClosed: - return - await asyncio.sleep(60) + await websocket.wait_closed() def require_token():