Commit graph

492 commits

Author SHA1 Message Date
Kay0u
eb9ecb6451
try catch is magic 2020-03-29 01:27:41 +01:00
Alexandre Aubin
06d8c48918 Fixing a super weird issue ljf encountered where the reader crashed because couldn't read the filescriptor ... Yolocommiting, let's see if this breaks something during our tests during next weeks ... 2020-03-29 00:41:37 +01:00
Bram
11ab539bac
Merge pull request #234 from kay0u/staticmethod-and-format_arg_names-fix
staticmethod and format_arg_names fix
2020-03-04 17:29:47 +01:00
Kay0u
a47a230611
staticmethod and format_arg_names fix 2020-01-14 22:45:19 +07:00
Kay0u
142081a934
be able to mock ldap uri 2020-01-08 01:38:36 +08:00
Kay0u
1ea4ce099b
fix comment 2020-01-07 23:56:25 +08:00
Kay0u
d4cc5ba12e
fix new_rdn 2020-01-07 23:55:52 +08:00
Kay0u
89aef100f0
action in ldap_operation_error 2020-01-07 23:55:37 +08:00
Kay0u
f05cc2c66a
test_ldap... to be continued 2020-01-07 17:47:50 +08:00
Kay0u
6a5971bb3c
better fix for lockfile 2020-01-07 01:15:26 +08:00
Kay0u
6490184333
format 2020-01-02 23:41:21 +08:00
Kay0u
247411cb9f
make flake8 happy 2020-01-02 23:39:35 +08:00
Kay0u
3abde9c008
default use global conf 2020-01-02 12:59:16 +08:00
Kay0u
0be1d74e4a
set handler if no password is provided 2020-01-02 12:34:47 +08:00
Kay0u
ce5d7ddaf0
fix conf authenticate all 2020-01-02 12:31:35 +08:00
Kay0u
94ccd9b05c
use the right authenticator 2020-01-02 12:30:43 +08:00
Kay0u
ac4a4c34b1
use default authenticator if none is defined 2020-01-02 12:17:12 +08:00
Kay0u
6f7f870d3d
use default profile by default 2020-01-02 12:14:23 +08:00
Kay0u
d51bb55573
add some members to authenticators 2020-01-02 12:12:24 +08:00
Kay0u
d4b58ed97f
Warn messages + fix error message 2019-12-28 23:30:36 +08:00
Kay0u
7f0a0608e8
expose msignals 2019-12-28 23:30:10 +08:00
Josué Tille
7ff033090c
Add warning when nothing is updated in LDAP 2019-12-23 11:01:53 +01:00
Josué Tille
9400ef7498
Don't update LDAP if there are nothing to do 2019-12-22 12:16:34 +01:00
Kay0u
6edc021f83
Add more tests 2019-12-22 00:36:20 +08:00
Kay0u
641126e344
Minimal change to support python3 2019-12-20 16:09:57 +08:00
decentral1se
54b8cab133 Apply Black on all the code base 2019-11-25 17:21:13 +01:00
Alexandre Aubin
952d707362 Make the linter gods happy 2019-11-20 00:27:34 +01:00
Alexandre Aubin
53ab4709d1 Rewrite auth tests in a more clean way, now using webtest to run the API 2019-11-19 21:12:58 +01:00
Alexandre Aubin
9fda7f4716 Merge branch 'stretch-unstable' into simplify-auth-mechanism 2019-11-19 16:55:06 +01:00
Alexandre Aubin
dcfd70c5df Import hmac, used for compare_digest 2019-11-19 16:50:13 +01:00
Alexandre Aubin
06e72c0e86 Simplify cache code.. 2019-11-19 16:49:45 +01:00
Alexandre Aubin
e14d156650
Space typo
Co-Authored-By: Timost <Timost@users.noreply.github.com>
2019-11-19 14:42:19 +01:00
Alexandre Aubin
f1087662a0
Use hmac.compare_digest to compare hashes
Co-Authored-By: Timost <Timost@users.noreply.github.com>
2019-11-19 14:19:35 +01:00
frju365
cfeaf52309
[fix] blank spaces for travis. 2019-11-03 14:36:21 +01:00
frju365
cb4057eabc
[fix] Return nothing if argument is already set. 2019-11-03 14:19:36 +01:00
Alexandre Aubin
e77e27730b
Update moulinette/authenticators/__init__.py
Co-Authored-By: Timost <Timost@users.noreply.github.com>
2019-11-01 16:47:05 +01:00
Alexandre Aubin
808f6203fd Allow to customize color for CLI prompts 2019-09-27 17:40:44 +02:00
Luke Murphy
cef72f7de9
Add some unit tests for the actionsmap module 2019-09-11 00:47:10 +01:00
Alexandre Aubin
97aad385b4
Add comment about the _authentiate_session mechanism 2019-08-30 20:13:17 +02:00
Luke Murphy
2c84ee1541
Add tests for text/serialize modules
Also take a pass on the docstrings.
2019-08-28 17:57:16 +02:00
Alexandre Aubin
050a982c93 Add note 2019-08-23 02:40:41 +02:00
Alexandre Aubin
2addea1e08 Implement basic tests for auth mechanism 2019-08-23 02:37:57 +02:00
Alexandre Aubin
6d44c46740 Be able to run test on the API 2019-08-22 03:27:31 +02:00
Alexandre Aubin
6899217fa0 Make linter gods happy 2019-08-21 16:22:16 +02:00
Alexandre Aubin
0a13e5b000 Fix is_authenticated mechanism 2019-08-21 16:12:03 +02:00
Alexandre Aubin
d7a33e5a14 Typo 2019-08-21 16:11:07 +02:00
Alexandre Aubin
7482f052f6 Get rid of gnupg, just store a hash of the id:token to reauthenticate later using session info 2019-08-20 20:31:10 +02:00
Alexandre Aubin
3822496622 Try to improve semantic : s_hash -> s_token 2019-08-20 19:53:51 +02:00
Alexandre Aubin
bcaf8b2e4a Move clean_session with the other session management method + add a check for session.hashed for additional security ? 2019-08-20 19:42:32 +02:00
Alexandre Aubin
ebc37ea014 Move init_authenticator to actionsmap.py for clarity to avoid spreading this shit over 72 files 2019-08-20 05:55:06 +02:00
Alexandre Aubin
65fe685a90 Get rid of this 'help' madness and more generally this three-tuppled containing various tuples and weird stuff ... use a simple dict everywhere instead 2019-08-20 05:43:17 +02:00
Alexandre Aubin
cad2cd8006 Get rid of the _format_conf madness. Instead, have clear functions to define if authentication is required, trigger the auth process if so 2019-08-20 05:43:09 +02:00
Alexandre Aubin
968667d9ed Try to improve the semantic of where/when the auth happens... 2019-08-20 03:32:52 +02:00
Alexandre Aubin
8d77fdb9a4 Cleaned unused stuff or overly complicated for no reason 2019-08-20 03:31:37 +02:00
Alexandre Aubin
83d9e772e7 Nowadays we don't have .errno anymore ? 2019-08-20 00:45:05 +02:00
Alexandre Aubin
3878ffdc04
Merge pull request #213 from YunoHost/detailed_error_messages_for_assert
[mod] add detail error messages on asserts
2019-08-18 14:12:56 +02:00
Alexandre Aubin
b393d55ebd Gotta catch them all... 2019-08-05 18:01:05 +02:00
Alexandre Aubin
2e2e627894 [yolo] Add a write_to_yaml utility similar to write_to_json 2019-08-05 17:59:10 +02:00
Luke Murphy
d52a574f77 Test documentation under Tox 2019-08-04 19:46:20 +02:00
Laurent Peuch
f49c004a59 [mod] add detail error messages on asserts 2019-08-04 18:48:16 +02:00
Alexandre Aubin
758778a04b Typo 2019-08-03 21:24:48 +02:00
Luke Murphy
659e20d5f5
Import DATA_DIR correctly
Fix for f6bfabc7aa.
2019-08-01 16:51:04 +02:00
Alexandre Aubin
f6bfabc7aa
Merge pull request #207 from decentral1se/refactor-global-loading
Refactor global loading
2019-08-01 12:20:38 +02:00
Luke Murphy
dfd0868510
Use flake8 under Tox and fix complaints 2019-07-29 13:26:16 +02:00
Laurent Peuch
1f10529209 [fix] syntax error, again -_-' 2019-07-29 03:56:10 +02:00
Laurent Peuch
599bec33b8 [fix] bad key, we aren't in self.local situation 2019-07-29 02:44:04 +02:00
Luke Murphy
14a3d63453
Test the cache file opening and creation 2019-07-28 22:04:07 +02:00
Luke Murphy
e027a188a9
Refactor exposing of global configuration
We do this to make it easier to control this value during testing. We
should not import these values at package setup time. Nor should we
import them at package load time.

This change introduces a new API for the Moulinette package. The
moulinette.env accessor. This is a breaking change. However, I've
searched around and can't seem to find any usage that relies directly on
these properties being available.

I've tried to maintain API backwards compatibility in all cases
otherwise.
2019-07-28 22:04:07 +02:00
Laurent Peuch
737f2dd967 [fix] missing argument for translation string formatting 2019-07-28 21:38:19 +02:00
Laurent Peuch
2403ee1b7d [mod] during tests failed to translate string is an error 2019-07-28 21:29:50 +02:00
Laurent Peuch
fdf9a719f1 [mod] way better failed translation error messages 2019-07-28 21:27:41 +02:00
Laurent Peuch
a8966b8643 [mod] add more message to inform users that some stuff are a warning 2019-07-28 21:14:24 +02:00
Bram
76c8620861
Merge pull request #205 from YunoHost/warning_long_lock
Warn the user about long locks for a way better UX
2019-07-28 18:56:43 +02:00
Bram
a22208ce40
[fix] typo, created a tuple instead of a string 2019-07-28 15:28:17 +02:00
Bram
bce7aee510
Merge pull request #208 from YunoHost/better_debug_gpg
Better debug information related to gpg for storing session
2019-07-28 06:02:50 +02:00
Bram
b7d415dc2c
[ux] make warning clearer because users often report it 2019-07-26 18:29:19 +02:00
Laurent Peuch
ca49ffefc1 [ux] also inform the user once we've stopped waiting for the lock 2019-07-25 04:15:52 +02:00
Laurent Peuch
79347af868 [mod/ux] display the real error when failed to retrieve session 2019-07-23 04:00:37 +02:00
Alexandre Aubin
3c9230ee9f
Merge pull request #204 from YunoHost/toml-utils
add utils.filesystem.read_toml and depends on toml in moulinette
2019-07-21 13:34:28 +02:00
Laurent Peuch
9c6c92b2c1 [mod] death to silent unverbose errors èwé 2019-07-20 16:03:30 +02:00
Bram
d72340f536
[mod] typo in comment
Co-Authored-By: decentral1se <lukewm@riseup.net>
2019-07-20 14:44:23 +02:00
Laurent Peuch
44878d7148 [ux] add a warning mecanism to inform the user about the current lock 2019-07-20 05:53:00 +02:00
Laurent Peuch
02c320f553 [mod] add debug log telling we are trying to aquired the log 2019-07-20 05:52:08 +02:00
Luke Murphy
ee1c67811b
Migrate utility tests to Pytest top level folder 2019-07-14 11:58:57 +02:00
Luke Murphy
5744dbd6fa
Use correct key for this locale lookup 2019-07-14 11:58:57 +02:00
Luke Murphy
14c4fafd39
Localise import to avoid setuptools install error 2019-07-14 01:31:38 +02:00
Luke Murphy
b78a7ca584
Make globals overridable 2019-07-14 01:31:37 +02:00
Laurent Peuch
7b65a3b6c2 [enh] add read_toml util 2019-07-07 05:48:10 +02:00
Josué Tille
e91ab96cb7
Fix pep 2019-05-28 22:13:26 +02:00
Josué Tille
a951b6f9a2
Add the possibility to filter the returned entry 2019-05-26 00:45:44 +02:00
Josué Tille
eeadb2ce17
Create a LDIF parser 2019-05-25 23:50:59 +02:00
Alexandre Aubin
ff6343c53a Merge branch 'stretch-unstable' into sasl_authentication 2019-05-02 15:20:33 +02:00
Alexandre Aubin
0e16546af9 [fix] Microdecision : do not miserably crash if the lock does not exist when attempting to release it 2019-04-08 18:15:00 +02:00
Alexandre Aubin
0a300e50d7 [microdecision] Fix case where stdinfo is not provided 2019-03-22 01:03:33 +01:00
Alexandre Aubin
1e90dd4bb1
Make sure gpg actually does something (#182) 2018-12-18 16:17:17 +01:00
Alexandre Aubin
1ce8ea9ffc
Merge branch 'stretch-unstable' into autopep8 2018-12-15 15:13:25 +01:00
Alexandre Aubin
e6c41b100b
Merge pull request #180 from irina11y/enh-moulinette-error
[enh] Simplify moulinette errors
2018-12-15 15:08:58 +01:00
Alexandre Aubin
5ec49c1b80 StandardError -> Exception (for python3 compat') 2018-12-14 16:24:04 +00:00
Alexandre Aubin
8e91c0d0d3 Get rid of error_to_response and trigger 400 error for all MoulinetteErrors instead 2018-12-14 16:21:48 +00:00
Alexandre Aubin
fddf64a20d __raw_msg__ -> raw_msg 2018-12-14 14:20:37 +00:00
Alexandre Aubin
22bfd1dbef autopep8 + a few manual tweaks 2018-12-13 19:14:29 +00:00
Josue-T
a3436d1146 [fix] Automatically reconnect LDAP authenticator when slapd restarts (#185)
* Fix LDAP authenticator when slapd was restarted
* Update parameter for LDAP reconnection
2018-12-13 15:58:00 +01:00
Alexandre Aubin
df7ee42254 Allow to bypass m18n if a raw message is given 2018-12-12 19:36:43 +00:00
Alexandre Aubin
a58d4dbb87 Remove old m18n.g and errno 2018-12-12 13:54:01 +00:00
Irina LAMBLA
a6cce50977 corrections 2018-12-12 13:37:00 +00:00
Irina LAMBLA
6614d8c76b use StandardError 2018-12-12 13:37:00 +00:00
Irina LAMBLA
dcf4c8fcf0 Enh Simplify moulinette error 2018-12-12 13:37:00 +00:00
Alexandre Aubin
9a8b5c080a
Merge pull request #181 from YunoHost/LDAP_validate_uniqueness
Add possiblity to get attribute name of conflict in LDAP
2018-12-12 13:13:57 +01:00
Josué Tille
35988d9273 Use sasl authentication for LDAP (by root user) 2018-12-11 21:04:14 +01:00
ljf
8b8296e87b [fix] Better way to calculate locale timezone 2018-12-10 01:17:04 +01:00
ljf
57602c5a1c [enh] Transform naive date into UTC aware date 2018-12-10 00:00:49 +01:00
ljf
5125d948af [enh] Display date as system timezone 2018-12-09 19:30:54 +01:00
Gabriel Corona
84c9a74d33 Protect against CSRF (#171) 2018-12-02 02:32:59 +01:00
Josué Tille
f14bb8a928 Fix typo 2018-11-29 17:03:21 +01:00
Josué Tille
b64e2d768c Fix identation 2018-11-26 09:41:07 +01:00
Josué Tille
d015732fa4 Add possiblity to get attribute name of conflict in LDAP 2018-11-25 23:05:30 +01:00
airwoodix
3c8d8b3465 Tidy up unused imports & other minor coding style adjustments 2018-11-22 22:56:47 +01:00
airwoodix
086d176c28 Adjust coding style to make CI build pass.
Coding style checker: pep8 --ignore E501,E128,E731 <...>
2018-11-22 22:46:42 +01:00
airwoodix
9044906698 Fix 'force' semantics in 'utils.filesystem.mkdir' 2018-11-22 22:00:41 +01:00
Alexandre Aubin
4b94bf6585
Allow to add comments to parameters (#175) 2018-11-04 16:00:12 +01:00
ljf (zamentur)
9f7ee73b09 [fix] Unapropriate warning (#173)
* [fix] Unapropriate warning

* Use 'is None'

Co-Authored-By: alexAubin <alex.aubin@mailoo.org>
2018-10-27 17:58:45 +02:00
Alexandre Aubin
efa9c9bd69 Merge branch 'stretch-unstable' into stdinfo 2018-08-22 17:09:57 +00:00
Laurent Peuch
c3f4f8e58b [mod] return the informated string, it's give more information to the user 2018-08-06 02:38:24 +02:00
Laurent Peuch
a26258e418 [mod] fallback on english on failure 2018-08-06 02:38:07 +02:00
Laurent Peuch
abc2085631 [mod] stronger warning messages 2018-08-06 02:37:38 +02:00
Laurent Peuch
8f2d094e0c [fix] don't crash when failed to format a translatable string 2018-08-06 02:31:22 +02:00
Alexandre Aubin
6f9bb54542 Microdecision: prefix info messages with blue 'Info:' 2018-07-25 14:38:37 +00:00
Laurent Peuch
cbd2c1611c [fix] this error can also occur and is fixed by regenerating the cache https://paste.yunohost.org/uvojidumik.rb (reported from support chan) 2018-07-20 14:11:29 +02:00
Bram
9bf2642539
Merge pull request #166 from YunoHost/async_callback_in_main_process
[mod] execute async consumers in the main process
2018-07-09 19:59:14 +02:00
Laurent Peuch
9b700e0a37 [fix] sometime we get an empty string 2018-06-25 15:16:31 +02:00
Laurent Peuch
75a21ad812 [mod] execute async consumers in the main process 2018-06-24 11:03:40 +02:00
ljf (zamentur)
c83d582313
[fix] Bad comment 2018-06-09 11:41:26 +02:00
ljf (zamentur)
cf07c34fe3
[enh] Use isoformat date RFC 3339 2018-06-09 11:38:43 +02:00
ljf
4e4fb4125b [fix] Display the date in a correct format 2018-06-05 17:57:06 +02:00
Laurent Peuch
f8a1a6aabb [enh] new utils to read yaml files 2018-05-12 06:03:06 +02:00
Bram
1830b229a8
[fix] avoid cases where get_cookie returns None
Reference https://bottlepy.org/docs/dev/api.html#bottle.BaseRequest.get_cookie

Might now be the most beautiful solution ever but at least it will produce a real error message.
2018-04-29 17:17:43 +02:00
Alexandre Aubin
97f8593ba1
Merge pull request #158 from pitchum/perf-debug
* Logging time needed to load the python module for an action (versus time needed to execute it).
* Lazy load some python imports (perfs improved a lot).
2018-04-26 17:00:22 +02:00
Laurent Peuch
455b7e49c0 [mod] remove catch-all try and provide real exception 2018-04-24 11:13:45 +02:00
pitchum
cd4581c3df Lazy load some python imports (perfs improved a lot). 2018-04-22 01:24:26 +02:00
pitchum
4e379dcf9f Logging time needed to load the python module for an action (versus time needed to execute it). 2018-04-22 01:24:26 +02:00
Laurent Peuch
7207a3218d [fix] pep8 2018-01-05 02:22:42 +01:00
Alexandre Aubin
e3571eb93a Cleaning / looks like it's working :/ 2017-11-04 19:43:38 +01:00
Alexandre Aubin
8151ab3caf (╯°□°)╯︵ ┻━┻ 2017-11-04 01:36:38 +01:00
Alexandre Aubin
37918d9816 [fix] Go to sleep Alex, you drunk 2017-10-29 23:58:54 +01:00
Alexandre Aubin
013e1155f9 [fix] Fix display of 'INFO' messages in --verbose 2017-10-29 23:12:34 +01:00
Alexandre Aubin
4f31cf0044 [enh] Handle a particular 'stdinfo' output through named pipe 2017-10-29 23:12:03 +01:00
Alexandre Aubin
0665cb4dd5 Allow to give lock to multiple processes (#154)
* Check also son_of_locked for self
* Check again that we're son of locked when trying to acquire lock
* Support having multiple PIDs in lock file..
* Fix/improve son_of_lock detection
2017-10-08 23:49:21 +02:00
Alexandre Aubin
ca580bbcfb Optional expected status code for download_text/json (#153) 2017-09-20 00:09:14 +02:00
Laurent Peuch
276b2013fe [mod] try to play with build-depends 2017-08-22 15:52:11 +02:00
Alexandre Aubin
331e7e8539 Adding docsting for download_json 2017-08-20 16:51:23 -04:00
Laurent Peuch
c73cca3f40 [fix] bad hack to handle the limitation of our buildchain 2017-08-20 03:48:20 +02:00
Laurent Peuch
dfcfecc84a Merge pull request #151 from YunoHost/enh-simpler-lock-system
[enh] Simpler lock system
2017-08-18 04:12:56 +02:00
Laurent Peuch
6aa22000cd [fix] handle post-install 2017-08-18 02:03:22 +02:00
Laurent Peuch
2d4018c82c [fix] auto upgrade admin password to sha-512 on login 2017-08-15 12:40:43 +02:00
Alexandre Aubin
d28990350c pep8 <3 2017-08-13 17:18:17 -04:00
Alexandre Aubin
ab47f30f18 Forget about the old BYPASS_LOCK thing from actionmap 2017-08-13 16:40:44 -04:00
Alexandre Aubin
9006f8980f [enh] Check if parent already has lock 2017-08-13 16:22:58 -04:00
Laurent Peuch
a0ce7a634b [enh] microdecision: allow subcategories to have a '-' in their name 2017-08-12 12:05:20 +02:00
Alexandre Aubin
7b0ad0901a [enh] Show description of command in --help (#148) 2017-08-07 15:28:23 +02:00
Laurent Peuch
09f49e4a8a [mod] pep8 2017-08-05 12:03:33 +02:00
Laurent Peuch
5bf2f46f47 Merge pull request #143 from YunoHost/support-subcategories
[enh] Support subcategories
2017-08-05 11:48:22 +02:00
Laurent Peuch
1efa5c8b6e Merge pull request #145 from YunoHost/refactoring2
Remove globals variables magic and add explicit import now
2017-08-05 11:48:06 +02:00
Laurent Peuch
bb3f685c90 [fix] too many %s in string formatting 2017-08-03 15:28:12 +02:00
Alexandre Aubin
0bbd47c090 Merge branch 'unstable' into support-subcategories
Conflicts:
	moulinette/actionsmap.py
2017-07-29 12:38:18 -04:00
Laurent Peuch
e9bc14845a [enh] Make ActionsMap._construct_parser code more readable (#144)
* [mod] autopep8
* [mod] remove useless try/except
* [mod] renaming + comment
* [mod] remove debug print
* [mod] more renaming
* [doc] explicit comment
* [mod] more renaming
* [mod] more renaming and comments
* [mod] more renaming
* [doc] usefull comment
* [mod] more renaming
* [mod] this is always true
* [mod] remove conditions that are always True
* [mod] more renaming
* [doc] add a comment from the docstring
* [mod] remove useless exception
* [mod] remove useless ()
* [mod] style
* [mod] it's better to fail than to silencly ignore a typo
* [mod] more renaming
* [doc] add a comment to avoid looking at yet-another-file
* [mod] renaming, make method name match reality and had a method for code readability
* [mod] remove one indirection level
* [mod] we always have actions
* [doc] add more comments
* [mod] simplify code again
* [mod] case never happen
* [mod] delegate responsability to class to make code more readable
* [mod] finish moving _add_arguments down to parsers
* [mod] invert conditions to make things more readable
* [mod] style
* [mod] remove useless exception
* [mod] simplify code
2017-07-29 17:45:36 +02:00
Alexandre Aubin
8960b1a610 [fix] Correctly handle error 500 (#142)
* [fix] Correctly handle error 500
* [fix] Remove unwanted change in error_to_response
2017-07-27 16:29:55 +02:00
Laurent Peuch
7266e7de15 [mod] rename variable 2017-07-26 05:31:38 +02:00
Laurent Peuch
e2ff1dca39 [mod] simplify code again 2017-07-26 05:28:56 +02:00
Laurent Peuch
b8b3c8db9f [mod] simplify, called code should never raised 2017-07-26 05:27:11 +02:00
Laurent Peuch
c326ae2c2b [mod] clean code of try/cache mess 2017-07-26 05:25:09 +02:00
Laurent Peuch
ffdb535918 [mod] simplifu code, remove global pkg object 2017-07-26 05:14:36 +02:00
Laurent Peuch
b4d36b2d3e [mod] more eleguant way of removing globals: from moulinette import m18n, pkg works 2017-07-25 21:19:51 +02:00
Laurent Peuch
863c3dd050 [mod] proposition to remove globals magic 2017-07-25 16:18:09 +02:00
Laurent Peuch
e6cffbc3e2 [mod] remove one global 2017-07-25 16:11:44 +02:00
Laurent Peuch
e0a50487ec [fix] microdecision, obviously bad method declaration 2017-07-25 16:09:30 +02:00
Alexandre Aubin
51ea069801 [microdecision] Remove unused imports + make pep8 happy 2017-07-24 14:35:58 -04:00
Alexandre Aubin
74281816b4 Add subcategory stuff for the API to work 2017-07-23 16:16:10 -04:00
Alexandre Aubin
6a6fb89fd0 Dirty hack to be able to display 'actions' and 'subcategories' in different section in --help 2017-07-23 15:47:20 -04:00
Alexandre Aubin
4b27bf6e83 Correctly call actions inside subcategories 2017-07-23 09:34:32 -04:00
Alexandre Aubin
30d6b30569 Removing debug prints 2017-07-23 09:25:33 -04:00
Alexandre Aubin
c01cef3147 Adding actions to subcategory 2017-07-23 09:17:27 -04:00
Alexandre Aubin
f595c37a4a Adding basic subcategory loop 2017-07-23 09:13:53 -04:00
Laurent Peuch
66111c9b8c [mod] case never happen 2017-07-23 05:34:01 +02:00
Laurent Peuch
8d94e1aa43 [mod] simplify code again 2017-07-23 05:19:47 +02:00
Laurent Peuch
5194eb75c4 [doc] add more comments 2017-07-23 05:19:38 +02:00
Laurent Peuch
e65e6f5990 [mod] we always have actions 2017-07-23 04:46:01 +02:00
Laurent Peuch
2c368596e9 [mod] remove one indirection level 2017-07-23 04:44:13 +02:00
Laurent Peuch
1caa172072 [mod] renaming, make method name match reality and had a method for code readability 2017-07-23 04:16:12 +02:00
Laurent Peuch
79bb5b427f [doc] add a comment to avoid looking at yet-another-file 2017-07-23 03:54:56 +02:00
Laurent Peuch
5f34437704 [mod] more renaming 2017-07-23 03:51:18 +02:00
Laurent Peuch
7853dda9fc [mod] it's better to fail than to silencly ignore a typo 2017-07-23 03:50:39 +02:00
Laurent Peuch
4fde7dd2a4 [mod] style 2017-07-23 03:48:16 +02:00
Laurent Peuch
0ded786883 [mod] remove useless () 2017-07-23 03:48:01 +02:00
Laurent Peuch
eed5cde8d2 [mod] remove useless exception 2017-07-23 03:47:52 +02:00
Laurent Peuch
a1395bdec6 [doc] add a comment from the docstring 2017-07-23 03:46:56 +02:00
Laurent Peuch
477d3721d1 [mod] more renaming 2017-07-23 03:46:41 +02:00
Laurent Peuch
70fdbd0188 [mod] remove conditions that are always True 2017-07-23 03:41:45 +02:00
Laurent Peuch
390b1ec17a [mod] this is always true 2017-07-23 03:40:37 +02:00
Laurent Peuch
681bba9ee1 [mod] more renaming 2017-07-23 03:35:57 +02:00
Laurent Peuch
61eaec0d53 [doc] usefull comment 2017-07-23 03:35:51 +02:00