YunoHost/package_linter
1
0
Fork 0
mirror of https://github.com/YunoHost/package_linter.git synced 2024-09-03 20:06:12 +02:00
Code Issues Projects Releases Packages Wiki Activity

Recommend ynh_print_info or ynh_script_progression usage in the install script

Browse source
This commit is contained in:
Alexandre Aubin 2019-02-10 14:12:25 +01:00
parent daee832af4
commit b27a848203
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
package_linter.py
View file

@ -427,6 +427,9 @@ def check_deprecated_practices(script):
if "systemctl restart nginx" in script["raw"] or "service nginx restart" in script["raw"]: if "systemctl restart nginx" in script["raw"] or "service nginx restart" in script["raw"]:
print_error("Restarting nginx is quite dangerous (especially for web installs) and should be avoided at all cost. Use 'reload' instead.") print_error("Restarting nginx is quite dangerous (especially for web installs) and should be avoided at all cost. Use 'reload' instead.")
if script["name"] == "install" and "ynh_print_info" not in script["shlex"] and "ynh_script_progression" not in script["shlex"]:
print_warning("Please add a few messages for the user, to explain what is going on (in friendly, not-too-technical terms) during the installation. You can use 'ynh_print_info' or 'ynh_script_progression' for this.")
def main(): def main():
if len(sys.argv) != 2: if len(sys.argv) != 2:
print("Give one app package path.") print("Give one app package path.")