Commit graph

417 commits

Author SHA1 Message Date
Kayou
856d7a957c
Merge pull request #129 from oleole39/patch-1
Fix regex in helpers_sourcing_after_official()
2024-02-20 07:47:42 +01:00
oleole39
7110959e51
Fix regex for source
Current regex will match any of the ten line after the official helper files starting with the string "source". 
Thus, in my specific case for which I declare a variable named source_filename="{...}", the linter will display a warning for it: `    ! Please avoid sourcing additional helpers after the official helpers (in this case file _filename=$(basename$upstream__url)) `.
As it should be only interested in matching the command `source` (`source path/to/file`), a space should be appended to the current regex.
2024-02-19 22:13:30 +01:00
Alexandre Aubin
8c00413d2f
Merge pull request #127 from orhtej2/more_set_headers_regex
Allow multiple whitespace after 'more_set_headers'
2024-02-12 20:08:36 +01:00
Alexandre Aubin
c3f223740f
Merge pull request #126 from orhtej2/verbose_error_nginx
Show offending lines for 'more_set_headers'
2024-02-12 20:08:22 +01:00
Alexandre Aubin
78b395ea68
Update package_linter.py 2024-02-12 20:08:14 +01:00
orhtej2
caee27ddaf Allow multiple whitespace after 'more_set_headers' 2024-02-10 21:32:56 +01:00
orhtej2
8ed7286c90 Show offending lines for 'more_set_headers' 2024-02-10 21:28:47 +01:00
Alexandre Aubin
d0c763ee28 Soft-deprecate packaging v1 on February 1st 2024, to be turned into an error on February 1st 2025 2024-01-26 15:22:09 +01:00
Alexandre Aubin
958bbe61e8 Don't miserably crash when failing to join() the error path when checking manifest schema 2024-01-17 03:48:26 +01:00
Alexandre Aubin
c989679ba3 Complain about using --line_match=Started/Stopped which is irrelevant/counterproductive 2023-12-28 05:15:30 +01:00
Alexandre Aubin
a8e5c7e67e Complain about using 'git clone' 2023-11-25 15:15:01 +01:00
Alexandre Aubin
67202bfa7b Tighten some info as 'warnings' (should only affect a handful of level 7+ apps nowadays) 2023-11-24 18:10:14 +01:00
Alexandre Aubin
cb892f1c42
Merge pull request #122 from orhtej2/flake8
Fixed (most) linter complaints.
2023-09-07 23:37:14 +02:00
orhtej2
3dcd83eb78 Fixed (most) linter complaints. 2023-09-07 23:11:03 +02:00
Tagada
b5b40510c9
Merge pull request #118 from orhtej2/patch-1
Consistently parse apt dependencies.
2023-09-06 22:50:12 +02:00
orhtej2
21815225cf
Consistently parse apt dependencies.
Make "x y" proper list of dependencies [`x`, `y`]  rather that of [`x y`]
2023-09-06 22:47:09 +02:00
Alexandre Aubin
c6cbd26235
Merge pull request #117 from Salamandar/fix_apt_linter
Fix package linter on apt list
2023-09-06 15:32:03 +02:00
Félix Piédallu
812fb0c996 Allow packages to be a list. Also, use the same splitting logic as in yunohost source code. 2023-09-06 13:53:54 +02:00
Alexandre Aubin
5d90885b49 phpconf: allow the usage of www-data for Group 2023-08-31 16:50:32 +02:00
tituspijean
afdefcc44b
Require init_main_permission question for webapps (#115)
* Require init_main_permission question for webapps

* Require init_main_permission question for webapps, fixed

Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org>

* Factorize a bit init_main_permission warning

Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org>

* Enhance init_main_permission warning

Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org>

---------

Co-authored-by: Alexandre Aubin <alex.aubin@mailoo.org>
2023-08-18 19:15:49 +02:00
tituspijean
0dd375db34 Fix jsonschema dependency installation 2023-07-25 20:32:20 +02:00
Alexandre Aubin
ea1f11b26b Add new schema validation for manifest v2 (only reports stuff as info for now) 2023-07-25 18:00:42 +02:00
Alexandre Aubin
6a5c346ecd nginx: complain about using $http_host rather than $host 2023-07-04 15:33:02 +02:00
Alexandre Aubin
50a325d27a Report http->https redirection as warning instead of info for app packaging v2 2023-07-04 15:12:10 +02:00
Alexandre Aubin
809c45601d Complain about the usage of YNH_DEFAULT_PHP_VERSION in _common.sh 2023-06-19 16:16:33 +02:00
Alexandre Aubin
a640c914df
manifest validation: missing 'continue' when some key doesnt exist to try to prevent miserably crashing (#113) 2023-06-10 23:50:05 +02:00
Alexandre Aubin
5c6da773a2
Merge pull request #112 from YunoHost/alexAubin-patch-1
having group = 'www-data' is a legit use case in php conf
2023-05-04 23:47:59 +02:00
Alexandre Aubin
8fe93728bf
having group = 'www-data' is a legit use case in php conf 2023-05-04 23:47:49 +02:00
Alexandre Aubin
e5b29238b2 Recategorize error as warning because it's clearly too aggressive @_@ 2023-04-01 14:07:40 +02:00
Alexandre Aubin
f281436e88
Merge pull request #110 from YunoHost/fix-v2
Fix location of PRE/POST_INSTALL.md files
2023-03-14 02:43:40 +01:00
Alexandre Aubin
3052fc966f Improve parsing of apt packages in v2 manifests 2023-02-26 13:01:40 +01:00
tituspijean
880cfd8668
Fix location of PRE/POST_INSTALL.md files 2023-02-21 23:08:35 +01:00
Alexandre Aubin
f0b1c81a9a Complain about dummy/placeholder messages in the doc/ folder 2023-02-20 19:34:13 +01:00
Alexandre Aubin
1b4f99575e Moving warnings from the core about consistency for apt resources vs database requirement 2023-02-20 18:02:27 +01:00
Alexandre Aubin
c90526dbd6 Remove unecessary warning about apps.json not existing 2023-02-15 19:20:58 +01:00
Alexandre Aubin
5d75cc2a73 Bump use of --package option in ynh_add_fpm_config as an error, we really gotta get rid of this legacy stuff 2023-02-15 19:19:43 +01:00
Alexandre Aubin
078f29de39 The app's catalog is in json now 2023-01-20 17:57:01 +01:00
Alexandre Aubin
c8abbe21a6 Require new tests.toml for apps v2 2023-01-16 23:40:33 +01:00
Alexandre Aubin
9fc8e0fb78 Be more resilient in case upgrade/backup/restore script dont exist for some reason 2023-01-11 09:46:19 +01:00
Alexandre Aubin
0f9b9aec73 Make doc/ folder mandatory for packaging v2 2023-01-11 09:45:55 +01:00
Alexandre Aubin
d8162daf30
Merge pull request #109 from selfhoster1312/progress_common
Warn when using ynh_script_progression in _common.sh
2023-01-08 20:47:51 +01:00
selfhoster1312
cbe1450d67 Change error to info and rephrase the message 2023-01-08 19:46:01 +01:00
selfhoster1312
e8fbcf6b5c Warn when using ynh_script_progression in _common.sh 2023-01-08 19:28:55 +01:00
Alexandre Aubin
3898d6ab1f Rework maintenance check because the info is now in the 'antifeatures' key in the catalog. Also refuse level 8 for apps flagged as deprecated, alpha or replaced by another app 2023-01-08 15:26:32 +01:00
Alexandre Aubin
b67409e3a8 Revert screenshot size warning to only info é_è 2022-12-23 23:31:16 +01:00
Alexandre Aubin
bd6ad626d9 Lazyload toml only when it's actually needed to simplify boring dependencies issues 2022-12-21 20:28:51 +01:00
Alexandre Aubin
935a984e95 Complain about 'website' in the manifest pointing to a code repo 2022-12-19 00:20:38 +01:00
Alexandre Aubin
b0cde49675 packagingv2: deprecate the nginx reload at the end of scripts ... there just no need for it :| 2022-12-04 03:30:45 +01:00
Alexandre Aubin
2ad2188805 Misc fixes 2022-12-04 03:24:45 +01:00
Alexandre Aubin
af8faf2088 Requalify a bunch of warning as error because the vast majority of apps now fixed these + complain about apps requiring only yunohost 4.0 / 4.1 + encourage usage of --usage/--footprint for php conf instead of huge php-fpm.conf 2022-12-03 20:13:41 +01:00