chore: rm some FIXME

This commit is contained in:
axolotle 2024-08-23 14:00:14 +02:00
parent d549d3fafc
commit 75925a203b
10 changed files with 0 additions and 12 deletions

View file

@ -12,7 +12,6 @@ defineSlots<{
<template> <template>
<div class="y-skeleton-wrapper"> <div class="y-skeleton-wrapper">
<div class="visually-hidden"> <div class="visually-hidden">
<!-- FIXME add `loading` translation -->
{{ $t('loading') }} {{ $t('loading') }}
</div> </div>

View file

@ -106,7 +106,6 @@ const modalComponent = computed(() => {
class="ms-auto" class="ms-auto"
> >
<template #button-content> <template #button-content>
<!-- FIXME i18n `quick_add` -->
<YIcon iname="plus" /> {{ t('quick_add') }} <YIcon iname="plus" /> {{ t('quick_add') }}
</template> </template>
<template v-for="(item, i) in quickAddItems" :key="i"> <template v-for="(item, i) in quickAddItems" :key="i">

View file

@ -20,7 +20,6 @@ const request = reactive<{
subStatus?: 'expired' | 'failed' subStatus?: 'expired' | 'failed'
}>({ }>({
status: 'pending', status: 'pending',
// FIXME translate
humanRoute: 'reconnecting', humanRoute: 'reconnecting',
}) })

View file

@ -234,7 +234,6 @@ export function formatOptions<MV extends Obj>(
fields: FormFieldDict<MV> fields: FormFieldDict<MV>
form: Ref<MV> form: Ref<MV>
} { } {
// FIXME handle optional for app install ? or is already handled in core bookworm?
const form = ref( const form = ref(
Object.fromEntries( Object.fromEntries(
options options
@ -332,7 +331,6 @@ function useExpression(
// FIXME normalize expression in core? ('', 'false', 'true') and rm next 2 lines // FIXME normalize expression in core? ('', 'false', 'true') and rm next 2 lines
if (!expression || expression === 'true') return true if (!expression || expression === 'true') return true
if (expression === 'false') return false if (expression === 'false') return false
// FIXME remove asUnreffed and manage ref type?
return useEvaluation(expression, form) return useEvaluation(expression, form)
} }
return true return true

View file

@ -27,7 +27,6 @@ type BaseDisplayItemProps = {
} }
export type ButtonItemProps = BaseDisplayItemProps & { export type ButtonItemProps = BaseDisplayItemProps & {
// FIXME compute enabled JSExpression
id: string id: string
enabled?: boolean | ComputedRef<boolean> enabled?: boolean | ComputedRef<boolean>
icon?: string icon?: string

View file

@ -42,7 +42,6 @@ const form = ref({
confirmation: '', confirmation: '',
}) })
const fields = { const fields = {
// FIXME satisfies FormFieldDict but not for CardForm?
alert: { alert: {
component: 'ReadOnlyAlertItem', component: 'ReadOnlyAlertItem',
cProps: { label: t('postinstall.user.first_user_help'), type: 'info' }, cProps: { label: t('postinstall.user.first_user_help'), type: 'info' },
@ -119,7 +118,6 @@ async function performPostInstall(force = false) {
{ removeEmpty: true }, { removeEmpty: true },
) )
// FIXME does the api will throw an error for bad passwords ?
api api
.post({ .post({
uri: 'postinstall' + (force ? '?force_diskspace' : ''), uri: 'postinstall' + (force ? '?force_diskspace' : ''),

View file

@ -86,7 +86,6 @@ const CheckboxList = createReusableTemplate<{
:key="partName" :key="partName"
class="d-flex justify-content-between align-items-center pe-0" class="d-flex justify-content-between align-items-center pe-0"
> >
<!-- FIXME use FormField or BFormGroup to get labels? -->
<div class="me-2"> <div class="me-2">
<h5 v-if="'id' in item"> <h5 v-if="'id' in item">
<span class="fw-bold me-1">{{ item.name }}</span> <span class="fw-bold me-1">{{ item.name }}</span>

View file

@ -33,7 +33,6 @@ const [search, filteredTree] = useSearch(domainsTree, (s, node) =>
:toggle-text="$t('domain.toggle_subdomains')" :toggle-text="$t('domain.toggle_subdomains')"
class="mb-5" class="mb-5"
> >
<!-- FIXME slot typing not appearing? -->
<template #default="{ data, parent }"> <template #default="{ data, parent }">
<div class="w-100 d-flex justify-content-between align-items-center"> <div class="w-100 d-flex justify-content-between align-items-center">
<h5 class="me-3"> <h5 class="me-3">

View file

@ -143,7 +143,6 @@ async function deleteGroup(name: string) {
humanKey: { key: 'groups.delete', name }, humanKey: { key: 'groups.delete', name },
}) })
.then(() => { .then(() => {
// FIXME primaryGroups as ref to override it ?
primaryGroups.value = primaryGroups.value.filter( primaryGroups.value = primaryGroups.value.filter(
(group) => group.name !== name, (group) => group.name !== name,
) )

View file

@ -26,7 +26,6 @@ const menu = [
] ]
</script> </script>
<!-- FIXME make a component shared with HomeView.vue ? -->
<template> <template>
<BListGroup class="menu-list"> <BListGroup class="menu-list">
<BListGroupItem <BListGroupItem