YunoHost/yunohost
1
0
Fork 0
mirror of https://github.com/YunoHost/yunohost.git synced 2024-09-03 20:06:10 +02:00
Code Issues Projects Releases Packages Wiki Activity

Naively migrate legacy and classical unprotected_uris = / that sets the app as public

Browse source
This commit is contained in:
Alexandre Aubin 2019-09-15 18:33:31 +02:00
parent c4743398e6
commit b2a26a64a7
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/yunohost/app.py
View file

@ -733,7 +733,7 @@ def app_install(operation_logger, app, label=None, args=None, no_remove_on_failu
from yunohost.hook import hook_add, hook_remove, hook_exec, hook_callback
from yunohost.log import OperationLogger
from yunohost.permission import user_permission_list, permission_create, permission_urls, permission_delete, permission_sync_to_user
from yunohost.permission import user_permission_list, permission_create, permission_urls, permission_delete, permission_sync_to_user, user_permission_update
# Fetch or extract sources
if not os.path.exists(INSTALL_TMP):
@ -952,7 +952,13 @@ def app_install(operation_logger, app, label=None, args=None, no_remove_on_failu
domain = app_settings.get('domain', None)
path = app_settings.get('path', None)
if domain and path:
# FIXME : might want to move this to before running the install script because some app need to run install script during initialization etc (idk) ?
permission_urls(app_instance_name+".main", add=[domain+path], sync_perm=False)
# Migrate classic public app still using the legacy unprotected_uris
if app_settings.get("unprotected_uris", None) == "/":
user_permission_update(app_instance_name+".main", remove="all_users", add="visitors", sync_perm=False)
permission_sync_to_user()
logger.success(m18n.n('installation_complete'))

6
src/yunohost/data_migrations/0011_setup_group_permission.py
View file

@ -113,6 +113,12 @@ class MyMigration(Migration):
user_permission_update(app+".main", remove="all_users", add=allowed_group, sync_perm=False)
app_setting(app, 'allowed_users', delete=True)
# Migrate classic public app still using the legacy unprotected_uris
if app_setting(app, "unprotected_uris") == "/":
user_permission_update(app+".main", remove="all_users", add="visitors", sync_perm=False)
permission_sync_to_user()
def run(self):
# FIXME : what do we really want to do here ...